Re: [pdm-devel] [PATCH manager/proxmox-datacenter-manager 0/6] Add SDN resources to dashboard + SDN zone overview tree

[Dominik Csapak <d.csapak@proxmox.com>]

looks mostly ok, see my comments on the individual patches

On 9/9/25 12:08 PM, Stefan Hanreich wrote:
> ## Introduction
> 
> This patch series adds the SDN cluster resources to the existing resource
> infrastructure in PDM. It also adds a small panel to the dashboard that gives an
> aggregated count of the status of SDN zones across all remotes. It also adds the
> SDN resources to the resource tree.
> 
> It adds a new menu entry: SDN that acts as the top-level for all SDN-related
> menu entries. The menu entry shows a tree of all SDN zones across all remotes,
> as well as their current status.
> 
> I've decided to model the SDN entities as an enum, since in the future we want
> to add additional SDN entities, and they all might have different properties.
> This avoids a type where all additional properties have Option<> as well as
> polluting the root Resource type with Sdn<Entity> variants.
> 
> ## Additional API endpoints:
> 
> * GET /resources/type/{resource_type}
> 
> ## Notes for reviewers:
> * is the structure for the SDN resources okay, or should we introduce a
>    dedicated resource for different SDN entities (i.e. PveSdnZone,
>    PveSdnFabric, .. instead of PveSdn(Zone::(_)))?

imho it's fine for me because we look at the sdn stuff differently, so
being able to easily filter them out/in is nicer.maybe someone else has 
a different opinion though


> * is the new API endpoint okay or should we just use the existing search
>    infrastructure for returning SDN resources instead of introducing a dedicated
>    API endpoint?

could we maybe add a 'type' filter on the list api call that does the
same you do? then we'd just have a single api endpoint but can still
filter efficiently for the type?

> 
> pve-manager:
> 
> Stefan Hanreich (1):
>    cluster: resources: add sdn property to cluster resources schema
> 
>   PVE/API2/Cluster.pm | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> 
> proxmox-datacenter-manager:
> 
> Stefan Hanreich (5):
>    pdm-api-types: add sdn cluster resource
>    server: api: add resources_by_type api call
>    ui: add sdn status report to dashboard
>    ui: images: add sdn icon
>    ui: sdn: add zone tree
> 
>   cli/client/src/resources.rs                  |  14 +
>   lib/pdm-api-types/src/resource.rs            | 159 +++++++++-
>   lib/pdm-client/src/lib.rs                    |  14 +-
>   lib/proxmox-api-types                        |   2 +-
>   server/src/api/resources.rs                  | 131 +++++++-
>   server/src/metric_collection/top_entities.rs |   1 +
>   ui/Makefile                                  |   1 +
>   ui/css/pdm.scss                              |  27 +-
>   ui/images/icon-sdn.svg                       |  70 +++++
>   ui/src/dashboard/mod.rs                      |  17 +-
>   ui/src/dashboard/sdn_zone_panel.rs           | 155 ++++++++++
>   ui/src/lib.rs                                |  13 +-
>   ui/src/main_menu.rs                          |  15 +-
>   ui/src/pve/remote.rs                         |   1 +
>   ui/src/pve/tree.rs                           |   1 +
>   ui/src/pve/utils.rs                          |  16 +-
>   ui/src/renderer.rs                           |   4 +
>   ui/src/sdn/mod.rs                            |   3 +
>   ui/src/sdn/zone_tree.rs                      | 299 +++++++++++++++++++
>   19 files changed, 929 insertions(+), 14 deletions(-)
>   create mode 100644 ui/images/icon-sdn.svg
>   create mode 100644 ui/src/dashboard/sdn_zone_panel.rs
>   create mode 100644 ui/src/sdn/zone_tree.rs
> 
> 
> Summary over all repositories:
>    20 files changed, 934 insertions(+), 14 deletions(-)
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel