From: Lukas Wagner <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior
Date: Tue, 8 Jul 2025 13:09:46 +0200 [thread overview]
Message-ID: <79e1d338-d492-483d-87b1-024c52c237c0@proxmox.com> (raw)
In-Reply-To: <20250626160626.311407-1-m.koeppl@proxmox.com>
On 2025-06-26 18:06, Michael Köppl wrote:
> This series aims to fix #3711 [0] and streamline the detach/remove
> behavior around volumes that are either mounted into a container or
> attached to a VM as a hard disk. It also contains adds warnings in case
> a volume's underlying storage does not exist anymore. It is a
> continuation of a series from 2022 [1], but makes the following changes:
>
[...]
Gave these changes a quick test on the latest master.
I tested:
- Remove {container,vm} after the the storage has been removed
-> does not fail any more, but shows a warning
- Remove a template if a linked clone exists
-> now fails with an error
Something that I have noticed is that when you have a second disk/mountpoint on
some storage, detach the disk/mountpoint, remove the storage and then
try to remove the unused disk, there is a difference in behavior between
containers and VMs. For VMs, the ununused disk can be removed, while for containers
the removal fails with:
unused0: unable to apply pending change unused0 : storage 'test' does not exist
Also did a brief review of the code. I'm not really familiar with these parts
of our stack, but from my point of view these changes look fine.
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-08 11:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 16:06 Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH storage v8 1/2] vdisk_free: print warning if underlying storage does not exist Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH storage v8 2/2] parse_volname: print warning if storage does not exists Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 1/4] fix #3711: warn about storage errors during mountpoint delete Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 2/4] destroy_lxc, delete_mp_volume: rename $volume to $volid Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 3/4] config: ensure valid volid through parse_volume() Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 4/4] add linked clone check when destroying container template Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 1/4] adapt linked clone check to not die if an error occurs during check Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 2/4] fix #3711: make removal of VM possible if store does not exist anymore Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 3/4] destroy_vm: use log_warn for vdisk_free errors for consistency Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 4/4] display warnings for storage errors or if storage no longer exists Michael Köppl
2025-07-08 11:09 ` Lukas Wagner [this message]
2025-07-15 16:29 ` [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79e1d338-d492-483d-87b1-024c52c237c0@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.