From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
Robert Obkircher <r.obkircher@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [PATCH v1 proxmox-backup 3/3] api: backup: disallow incremental backups with different index length
Date: Tue, 10 Mar 2026 19:40:03 +0100 [thread overview]
Message-ID: <79c907b2-23cd-4ccc-8620-35082f4240ec@proxmox.com> (raw)
In-Reply-To: <f3420608-8d13-41b9-b232-6fccd59a3d30@proxmox.com>
Am 10.03.26 um 18:15 schrieb Christian Ebner:
> On 3/10/26 5:09 PM, Robert Obkircher wrote:
>> Restore the previous restrictions because fixed index files are only
>> reused for qemu backups where the total size never changes.
btw. when increasing a vdisk size we (or others that want to backup a
fixed index to PBS) theoretically could reuse the previous bitmap,
extend it and mark the new area as dirty for efficiency, so this is
not something that is bogus out of principle.
Also, a bit more rationale would be appreciated here, especially in
combination with sending this along with a quite important bug fix.
next prev parent reply other threads:[~2026-03-10 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 16:03 [PATCH v1 proxmox-backup 0/3] fix incremental qemu backup Robert Obkircher
2026-03-10 16:03 ` [PATCH v1 proxmox-backup 1/3] api: backup: don't verify total file size for incremental backups Robert Obkircher
2026-03-10 17:03 ` Christian Ebner
2026-03-10 18:23 ` Thomas Lamprecht
2026-03-10 16:03 ` [PATCH v1 proxmox-backup 2/3] api: backup: improve schema documentation of fixed_close Robert Obkircher
2026-03-10 17:09 ` Christian Ebner
2026-03-10 16:04 ` [PATCH v1 proxmox-backup 3/3] api: backup: disallow incremental backups with different index length Robert Obkircher
2026-03-10 17:16 ` Christian Ebner
2026-03-10 18:40 ` Thomas Lamprecht [this message]
2026-03-10 17:11 ` [PATCH v1 proxmox-backup 0/3] fix incremental qemu backup Stoiko Ivanov
2026-03-10 17:34 ` Christian Ebner
2026-03-10 18:59 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79c907b2-23cd-4ccc-8620-35082f4240ec@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.