From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs] pve-network: correct language errors
Date: Tue, 13 Aug 2024 12:49:35 +0200 [thread overview]
Message-ID: <799bd407-3471-4ae2-b8ee-b83f7db30432@proxmox.com> (raw)
In-Reply-To: <20240813102305.6-2-a.zeidler@proxmox.com>
On 2024-08-13 12:23, Alexander Zeidler wrote:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> pve-network.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pve-network.adoc b/pve-network.adoc
> index acdcf39..434430d 100644
> --- a/pve-network.adoc
> +++ b/pve-network.adoc
> @@ -447,7 +447,7 @@ slaves in the single logical bonded interface such that different
> network-peers use different MAC addresses for their network packet
> traffic.
>
> -If your switch support the LACP (IEEE 802.3ad) protocol then we recommend using
> +If your switch supports the LACP (IEEE 802.3ad) protocol then we recommend using
^
There should be comma here: If ..., then ...
> the corresponding bonding mode (802.3ad). Otherwise you should generally use the
> active-backup mode.
>
> @@ -490,7 +490,7 @@ iface vmbr0 inet static
>
>
> [thumbnail="default-network-setup-bond.svg"]
> -Another possibility it to use the bond directly as bridge port.
> +Another possibility is to use the bond directly as bridge port.
> This can be used to make the guest network fault-tolerant.
>
> .Example: Use a bond as bridge port
Apart from this, this looks good to me:
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-08-13 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 10:23 Alexander Zeidler
2024-08-13 10:49 ` Lukas Wagner [this message]
2024-08-13 13:57 ` [pve-devel] applied: " Fiona Ebner
2024-08-13 13:58 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=799bd407-3471-4ae2-b8ee-b83f7db30432@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.