From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] api: config: permission checks: fix check for 'nesting' feature
Date: Mon, 10 Feb 2025 16:57:19 +0100 [thread overview]
Message-ID: <79878943-5e4f-4ed6-b351-b3f15181c395@proxmox.com> (raw)
In-Reply-To: <20250207163813.97461-1-f.ebner@proxmox.com>
Am 07.02.25 um 17:38 schrieb Fiona Ebner:
> As reported in the community forum [0], remote migration for a container
> with 'features: nesting=0' would fail with a confusing error message
>
>> changing feature flags (except nesting) is only allowed for root@pam
>
> This is because of a faulty check during container creation that would
> only detect 'nesting=1', but not 'nesting=0'. Fix it by properly
> checking if only the 'nesting' property is affected via an 'exists'
> check for the hash key.
>
> The check for deleting the feature is also broken, so fix it too.
>
> The check for modifying the feature already works correctly.
>
> [0]: https://forum.proxmox.com/threads/161432/
>
> Fixes: 88ef170 ("allow nesting to be changed for VM.Allocate on unprivileged containers")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/LXC.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-02-10 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 16:38 [pve-devel] " Fiona Ebner
2025-02-10 15:57 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79878943-5e4f-4ed6-b351-b3f15181c395@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.