all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] start node disk view unexpanded
@ 2021-07-06 12:20 Oguz Bektas
  2021-07-06 12:55 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2021-07-06 12:20 UTC (permalink / raw)
  To: pve-devel

gets clunky with a lot of disks and partitions when all of them are
expanded by default.
so we can set the default to 'false' and let the user expand as they wish.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---

requested by user on forum:
https://forum.proxmox.com/threads/start-disk-view-unexpanded.89195/


 src/panel/DiskList.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
index 90a6553..acbcdf6 100644
--- a/src/panel/DiskList.js
+++ b/src/panel/DiskList.js
@@ -168,7 +168,7 @@ Ext.define('Proxmox.DiskList', {
 	    for (const item of records) {
 		let data = item.data;
 		data.leaf = true;
-		data.expanded = true;
+		data.expanded = false;
 		data.children = [];
 		data.iconCls = 'fa fa-fw fa-hdd-o x-fa-tree';
 		if (!data.parent) {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH widget-toolkit] start node disk view unexpanded
  2021-07-06 12:20 [pve-devel] [PATCH widget-toolkit] start node disk view unexpanded Oguz Bektas
@ 2021-07-06 12:55 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-06 12:55 UTC (permalink / raw)
  To: Proxmox VE development discussion, Oguz Bektas

On 06.07.21 14:20, Oguz Bektas wrote:
> gets clunky with a lot of disks and partitions when all of them are
> expanded by default.
> so we can set the default to 'false' and let the user expand as they wish.
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> 
> requested by user on forum:
> https://forum.proxmox.com/threads/start-disk-view-unexpanded.89195/
> 

I do not want that, as by default I want to see more inforamtion.

Rather add a collapse all and expand-all tool and make that state-full so that the
last used one sticks. Could be done similar like what the api-viewer has (albeit that
one isn't state-full, but that should not be hard):

https://pve.proxmox.com/pve-docs/api-viewer/index.html




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-06 12:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 12:20 [pve-devel] [PATCH widget-toolkit] start node disk view unexpanded Oguz Bektas
2021-07-06 12:55 ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal