From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 2/2] ui: backup job details: show notification-mode instead of legacy keys
Date: Fri, 11 Jul 2025 09:41:17 +0200 [thread overview]
Message-ID: <795327d5-8394-4c4c-a5c9-428a3c99fed3@proxmox.com> (raw)
In-Reply-To: <e64c54f0-3df1-4871-8aa4-686e960bfd95@proxmox.com>
On 7/9/25 09:12, Lukas Wagner wrote:
> The parameter to the gettext function needs to be a static string, otherwise xgettext[1,2] cannot
> extract it to generate the .pot file. While the xgettext tool has some basic understanding of the
> syntax of supported languages to parse these strings, it does not evaluate or execute any code.
>
> That's also the reason why we have to do a
>
> Ext.String.format(gettext("... {0}"), var)
>
> instead of a
>
> gettext(`.... ${var}`)
I see, I hadn't considered that. Thanks for the detailed response and
the links!
>
> Also, I'm not the biggest fan of the ternary operator, I'm not sure if your suggestion is any easier
> to read and comprehend. But that might just be me :)
>
Yeah, you're probably right. Shortening the code should not come at the
expense of readability and thinking about it again, I prefer the way you
implemented this.
>
> [1] https://man7.org/linux/man-pages/man1/xgettext.1.html
> [2] https://git.proxmox.com/?p=proxmox-i18n.git;a=blob;f=Makefile;h=34859f5cfa776111b991da23e922cc5eb83cf306;hb=HEAD#l140
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-11 7:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 11:28 [pve-devel] [PATCH pve-guest-common v2 1/1] backup job: remove 'notification-policy' and 'notification-target' options Lukas Wagner
2025-06-24 11:28 ` [pve-devel] [PATCH manager v2 1/2] ui: remove handling of obsolete notification-policy/target settings Lukas Wagner
2025-06-24 11:28 ` [pve-devel] [PATCH manager v2 2/2] ui: backup job details: show notification-mode instead of legacy keys Lukas Wagner
2025-07-08 18:07 ` Michael Köppl
2025-07-09 7:12 ` Lukas Wagner
2025-07-11 7:41 ` Michael Köppl [this message]
2025-07-08 18:17 ` Michael Köppl
2025-07-09 8:18 ` Lukas Wagner
2025-07-11 7:42 ` Michael Köppl
2025-07-08 18:20 ` [pve-devel] [PATCH pve-guest-common v2 1/1] backup job: remove 'notification-policy' and 'notification-target' options Michael Köppl
2025-07-09 8:20 ` [pve-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795327d5-8394-4c4c-a5c9-428a3c99fed3@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.