Re: [pve-devel] [PATCH qemu-server v9 1/5] enable VNC clipboard parameter in vga_fmt

[Fiona Ebner <f.ebner@proxmox.com>]

This needs a rebase, but looks good to me other than a few nits.

Am 22.05.23 um 12:09 schrieb Markus Frank:
> added option to use the qemu vdagent implementation to enable the VNC
> clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu
> implementation.
> 

Nit: QEMU should be capitalized

> This patch does not solve #1406, but does allow copy and paste with
> a running X-session, when spice-vdagent is installed on the guest.
> 
> added vnc-clipboard variable to return at status/current
> 

Nit: This part could've been a separate patch

> By that noVNC is able to check if clipboard is active.
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---

(...)

> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 40be44d..8d30f7c 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -193,8 +193,16 @@ my $vga_fmt = {
>  	minimum => 4,
>  	maximum => 512,
>      },
> +    'vnc-clipboard' => {
> +	description => "enable VNC clipboard (requires spice tools in the guest)",

Nit: SPICE should be capitalized

"SPICE guest tools" seems to be the name for Windows, should we say
"SPICE guest tools/SPICE vdagent" instead?

> +	type => 'boolean',
> +	optional => 1,
> +	default => 0
> +    }

Style nit: missing trailing comma for the above two lines

>  };
>  
> +my $vnc_clipboard_regex = qr/^(std|cirrus|vmware|virtio|qxl)/;

I'd slightly prefer a hash with all the valid keys instead of a regex,
but no big deal.