[pbs-devel] [PATCH proxmox-backup] server: set http2 max frame size

[pbs-devel] [PATCH proxmox-backup] server: set http2 max frame size

[Fabian Grünbichler]

else we get the default of 16k, which is quite low for our use case.
this improves the TLS upload benchmark speed by about 30-40% for me.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 Cargo.toml         | 2 +-
 src/api2/backup.rs | 1 +
 src/api2/reader.rs | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Cargo.toml b/Cargo.toml
index 1e32d26d..b962010f 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -26,7 +26,7 @@ futures = "0.3"
 h2 = { version = "0.2", features = ["stream"] }
 handlebars = "3.0"
 http = "0.2"
-hyper = "0.13"
+hyper = "0.13.6"
 lazy_static = "1.4"
 libc = "0.2"
 log = "0.4"
diff --git a/src/api2/backup.rs b/src/api2/backup.rs
index 59f2792b..c00f9be8 100644
--- a/src/api2/backup.rs
+++ b/src/api2/backup.rs
@@ -159,6 +159,7 @@ async move {
                 let window_size = 32*1024*1024; // max = (1 << 31) - 2
                 http.http2_initial_stream_window_size(window_size);
                 http.http2_initial_connection_window_size(window_size);
+                http.http2_max_frame_size(4*1024*1024);
 
                 http.serve_connection(conn, service)
                     .map_err(Error::from)
diff --git a/src/api2/reader.rs b/src/api2/reader.rs
index 83ae616a..cf82af06 100644
--- a/src/api2/reader.rs
+++ b/src/api2/reader.rs
@@ -121,6 +121,7 @@ fn upgrade_to_backup_reader_protocol(
                         let window_size = 32*1024*1024; // max = (1 << 31) - 2
                         http.http2_initial_stream_window_size(window_size);
                         http.http2_initial_connection_window_size(window_size);
+                        http.http2_max_frame_size(4*1024*1024);
 
                         http.serve_connection(conn, service)
                             .map_err(Error::from)
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup] server: set http2 max frame size

[Dietmar Maurer]

applied

> On 09/10/2020 10:36 AM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
>  
> else we get the default of 16k, which is quite low for our use case.
> this improves the TLS upload benchmark speed by about 30-40% for me.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  Cargo.toml         | 2 +-
>  src/api2/backup.rs | 1 +
>  src/api2/reader.rs | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Cargo.toml b/Cargo.toml
> index 1e32d26d..b962010f 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -26,7 +26,7 @@ futures = "0.3"
>  h2 = { version = "0.2", features = ["stream"] }
>  handlebars = "3.0"
>  http = "0.2"
> -hyper = "0.13"
> +hyper = "0.13.6"
>  lazy_static = "1.4"
>  libc = "0.2"
>  log = "0.4"
> diff --git a/src/api2/backup.rs b/src/api2/backup.rs
> index 59f2792b..c00f9be8 100644
> --- a/src/api2/backup.rs
> +++ b/src/api2/backup.rs
> @@ -159,6 +159,7 @@ async move {
>                  let window_size = 32*1024*1024; // max = (1 << 31) - 2
>                  http.http2_initial_stream_window_size(window_size);
>                  http.http2_initial_connection_window_size(window_size);
> +                http.http2_max_frame_size(4*1024*1024);
>  
>                  http.serve_connection(conn, service)
>                      .map_err(Error::from)
> diff --git a/src/api2/reader.rs b/src/api2/reader.rs
> index 83ae616a..cf82af06 100644
> --- a/src/api2/reader.rs
> +++ b/src/api2/reader.rs
> @@ -121,6 +121,7 @@ fn upgrade_to_backup_reader_protocol(
>                          let window_size = 32*1024*1024; // max = (1 << 31) - 2
>                          http.http2_initial_stream_window_size(window_size);
>                          http.http2_initial_connection_window_size(window_size);
> +                        http.http2_max_frame_size(4*1024*1024);
>  
>                          http.serve_connection(conn, service)
>                              .map_err(Error::from)
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel