From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] tui: bootdisk zfs config: add a maximum value to the `copies` option
Date: Fri, 17 Nov 2023 17:41:40 +0100 [thread overview]
Message-ID: <770ad5ee-e571-4dc8-8e2b-3da447310fab@proxmox.com> (raw)
In-Reply-To: <20231117163218.533158-1-s.sterz@proxmox.com>
Am 17/11/2023 um 17:32 schrieb Stefan Sterz:
> according to `man zfsprops` the copies option can only be 1, 2, or 3.
> limit the field to 3, as setting higher options can't work anyway.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> i would have added a `min_value` of 1 too, but `IntegerEditView` is
> based on `NumericEditView` and that doesn't offer a minimal value.
>
> proxmox-tui-installer/src/views/bootdisk.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, fleeced in a note that we already limit that in the GTK UI
(for the exact reason you reference), thanks!
prev parent reply other threads:[~2023-11-17 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 16:32 [pve-devel] " Stefan Sterz
2023-11-17 16:41 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=770ad5ee-e571-4dc8-8e2b-3da447310fab@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal