From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] fix #6138: ui: storage content: use locale for sorting
Date: Tue, 4 Mar 2025 18:52:20 +0100 [thread overview]
Message-ID: <76e9401b-9dfa-48e5-ad25-415cfbd66c82@proxmox.com> (raw)
In-Reply-To: <20250304141452.2594160-1-d.csapak@proxmox.com>
Am 04.03.25 um 15:14 schrieb Dominik Csapak:
> by using 'localeCompare'.
>
> Assume the files 'a', 'B' and 'c'. The current default sorting results
> in :
>
> 'B'
> 'a'
> 'c'
>
> (C collation)
>
> With this patch we use locale dependent sorting, so the browser/client
> setting controls how it's sorted. For example with english, the list
> becomes:
>
> 'a'
> 'B'
> 'c'
>
> Which makes it easier to visually search for specific entries.
> Using the default settings here makes sense (so no explicit
> 'sensitivity' setting for example.), since that is whats most
> expected per locale.
>
> Also enable 'numeric' sorting, so 'foo10' is sorted after 'foo2'.
>
> Interestingly, the initial sorter (via the 'sorters' property of the
> store), cannot seem to reuse the sorter defined in the columns, so
> we have to specify it twice, once for the initial sort and once when
> the user clicks the column header.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * also include numeric sorting. Thanks @Fiona for noticing this!
>
> www/manager6/storage/ContentView.js | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-04 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 14:14 [pve-devel] " Dominik Csapak
2025-03-04 17:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e9401b-9dfa-48e5-ad25-415cfbd66c82@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.