Re: [pdm-devel] [PATCH proxmox-datacenter-manager 04/15] task cache: remove max-age machanism

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 28.01.25 um 13:25 schrieb Lukas Wagner:
> This commit removes the time-based caching policy for remote tasks. It
> will be replaced by another cache replacement policy based on total
> number of tasks in an upcoming commit.

high-level: Such commits really should state a rationale with some
background over why this approach has to be replaced. Noting that in
the cover letter too would also be appreciated, such things help to
"sell" series/PRs and having the underlying goal and/or pain points
spelled out, even if quite obvious, ensures everyone is on the same
page.

Similar comment for the next patch adding the FIFO replacement policy,
I won't write a separate mail for that.

I will try to check out the overall picture and the points up for
discussion you mention over the next days; that should not discourage
anybody else to review it though, and please holler at me should I
need longer.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel