From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [pbs-devel] [PATCH widget-toolkit v5 2/5] toolkit: add NotesView panel and NotesEdit window
Date: Wed, 13 Apr 2022 11:43:55 +0200 [thread overview]
Message-ID: <7667de36-4f88-b5c9-0bc1-71efbd658821@proxmox.com> (raw)
In-Reply-To: <20220412103423.3845322-3-s.sterz@proxmox.com>
On 12.04.22 12:34, Stefan Sterz wrote:
> move them here from pve so we can maintain them across several
> products
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> src/Makefile | 2 +
> src/panel/NotesView.js | 129 ++++++++++++++++++++++++++++++++++++++++
> src/window/NotesEdit.js | 38 ++++++++++++
> 3 files changed, 169 insertions(+)
> create mode 100644 src/panel/NotesView.js
> create mode 100644 src/window/NotesEdit.js
>
>
applied, thanks! It seems that I have wrongly conveyed that the 1:1 + changes in a
separate patch means a literal 1:1, changes that are required to avoid breakage (e.g.,
due to redefinition of existing source classes) should be still avoided.
So it's more like "move 1:1 as closely as possible without breaking the build and/or
product).
Anyhow, no biggie, so I just moved the class/xtypes renames into widget-toolkit patch
1 and noted in the commit message that I did so.
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH widget-toolkit v5 2/5] toolkit: add NotesView panel and NotesEdit window
Date: Wed, 13 Apr 2022 11:43:55 +0200 [thread overview]
Message-ID: <7667de36-4f88-b5c9-0bc1-71efbd658821@proxmox.com> (raw)
In-Reply-To: <20220412103423.3845322-3-s.sterz@proxmox.com>
On 12.04.22 12:34, Stefan Sterz wrote:
> move them here from pve so we can maintain them across several
> products
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> src/Makefile | 2 +
> src/panel/NotesView.js | 129 ++++++++++++++++++++++++++++++++++++++++
> src/window/NotesEdit.js | 38 ++++++++++++
> 3 files changed, 169 insertions(+)
> create mode 100644 src/panel/NotesView.js
> create mode 100644 src/window/NotesEdit.js
>
>
applied, thanks! It seems that I have wrongly conveyed that the 1:1 + changes in a
separate patch means a literal 1:1, changes that are required to avoid breakage (e.g.,
due to redefinition of existing source classes) should be still avoided.
So it's more like "move 1:1 as closely as possible without breaking the build and/or
product).
Anyhow, no biggie, so I just moved the class/xtypes renames into widget-toolkit patch
1 and noted in the commit message that I did so.
next prev parent reply other threads:[~2022-04-13 9:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 10:34 [pve-devel] [PATCH proxmox-backup v5 0/5] fix 3067: add notes functionality in webui Stefan Sterz
2022-04-12 10:34 ` [pbs-devel] " Stefan Sterz
2022-04-12 10:34 ` [pve-devel] [PATCH proxmox-backup v5 1/5] fix #3067: docs: add markdown primer from pve to pbs Stefan Sterz
2022-04-12 10:34 ` [pbs-devel] " Stefan Sterz
2022-04-25 9:44 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-25 9:44 ` [pbs-devel] applied: " Thomas Lamprecht
2022-04-12 10:34 ` [pve-devel] [PATCH widget-toolkit v5 2/5] toolkit: add NotesView panel and NotesEdit window Stefan Sterz
2022-04-12 10:34 ` [pbs-devel] " Stefan Sterz
2022-04-13 9:43 ` Thomas Lamprecht [this message]
2022-04-13 9:43 ` [pbs-devel] applied: " Thomas Lamprecht
2022-04-12 10:34 ` [pve-devel] [PATCH widget-toolkit v5 3/5] toolkit: refactor markdown based NotesView and NotesEdit Stefan Sterz
2022-04-12 10:34 ` [pbs-devel] " Stefan Sterz
2022-04-13 9:43 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-13 9:43 ` [pbs-devel] applied: " Thomas Lamprecht
2022-04-12 10:34 ` [pve-devel] [PATCH manager v5 4/5] ui: move NotesView panel and NotesEdit window to widget kit Stefan Sterz
2022-04-12 10:34 ` [pbs-devel] " Stefan Sterz
2022-04-26 14:09 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-26 14:09 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-04-12 10:34 ` [pve-devel] [PATCH proxmox-backup v5 5/5] fix #3067: ui: add a separate notes view for longer markdown notes Stefan Sterz
2022-04-12 10:34 ` [pbs-devel] " Stefan Sterz
2022-04-25 9:44 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7667de36-4f88-b5c9-0bc1-71efbd658821@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.