all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: metrics: check permissions before reading any data from the cache
Date: Wed, 16 Oct 2024 09:26:31 +0200	[thread overview]
Message-ID: <75dcd226-c733-42e1-9ea4-11b6bf64bdd0@proxmox.com> (raw)
In-Reply-To: <20241015135028.214111-1-l.wagner@proxmox.com>

Am 15/10/2024 um 15:50 schrieb Lukas Wagner:
> Reading from the metric cache is somewhat expensive, so validate as many
> of the required permissions as possible. For host metrics, we can
> do the full check in advance. For datastores, we check if we have
> audit permissions for *any* datastore. If we do not have privs for
> either of those, we return early and avoid reading from the
> cache altogether.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>

tiny nit: these should be normally switched, to keep the causal order intact.
I.e., the suggestion normally happens before you make the change that you
sign-off, that's also why r-b/t-b trailers should get added below ones s-o-b.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      parent reply	other threads:[~2024-10-16  7:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 13:50 Lukas Wagner
2024-10-15 14:04 ` [pbs-devel] applied: " Wolfgang Bumiller
2024-10-16  7:26 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75dcd226-c733-42e1-9ea4-11b6bf64bdd0@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal