From: Aaron Lauterer <a.lauterer@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>,
pve-devel@lists.proxmox.com,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times
Date: Wed, 10 May 2023 11:57:46 +0200 [thread overview]
Message-ID: <751e4986-6e54-f830-6908-2957ef5e958b@proxmox.com> (raw)
In-Reply-To: <ba17438f-e379-f1ae-c7c4-ea905d566dd6@proxmox.com>
On 5/9/23 16:43, Fiona Ebner wrote:
> Am 09.05.23 um 14:55 schrieb Aaron Lauterer:
>>
>> * Don't scan all storages and only look at disk images that are
>> referenced in the config. With this, we should have removed most
>> situations where aliases would happen, and a migration is less likely to
>> fail, because a storage is not online.
>
> I do prefer this approach as it also fixes issues like "unavailable, but
> enabled storage that's not even involved fails migration". And it's also
> more intuitive.
>
> But if we really do that, we need to be careful: In particular, we need
> to explicitly pick up volumes in the pending section (currently, that
> does only happen via the implicit scanning). There might be similar
> issues in other situations, but none that I'm aware of.
Thanks for the hint. I'll look into it. What could be such a scenario? Adding a
new disk or removing one with hot-plugging not working?
next prev parent reply other threads:[~2023-05-10 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 13:17 [pve-devel] [PATCH qemu-server, container 0/2] " Aaron Lauterer
2023-05-02 13:17 ` [pve-devel] [PATCH qemu-server 1/2] migration: " Aaron Lauterer
2023-05-03 9:17 ` Fabian Grünbichler
2023-05-09 7:34 ` Fiona Ebner
2023-05-09 12:55 ` Aaron Lauterer
2023-05-09 14:43 ` Fiona Ebner
2023-05-10 9:57 ` Aaron Lauterer [this message]
2023-05-10 11:23 ` Fiona Ebner
2023-05-02 13:17 ` [pve-devel] [PATCH container 2/2] migration: avoid migrating volume " Aaron Lauterer
2023-05-03 9:07 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=751e4986-6e54-f830-6908-2957ef5e958b@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.