From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] unbreak get_subscription without sshd installed
Date: Tue, 10 Nov 2020 17:52:11 +0100 (CET) [thread overview]
Message-ID: <751610710.1048.1605027131503@webmail.proxmox.com> (raw)
In-Reply-To: <1457363642.1045.1605024092426@webmail.proxmox.com>
> Dietmar Maurer <dietmar@proxmox.com> hat am 10.11.2020 17:01 geschrieben:
>
>
> Or make sure sshd is installed?
we don't require it for any functionality (except deriving the server ID, which can be done with any arbitrary somewhat static, server-specific file)
> > On 11/10/2020 4:59 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> >
> >
> > which might be the case e.g. in a PBS container
> >
> > Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> > ---
> >
> > Notes:
> > we might want to switch to a different file as base? or even generate a file
> > just for the server ID derivation?
> >
> > src/api2/node/subscription.rs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/api2/node/subscription.rs b/src/api2/node/subscription.rs
> > index 67797fd5..010a0209 100644
> > --- a/src/api2/node/subscription.rs
> > +++ b/src/api2/node/subscription.rs
> > @@ -94,7 +94,7 @@ pub fn get_subscription(
> > Ok(None) => SubscriptionInfo {
> > status: SubscriptionStatus::NOTFOUND,
> > message: Some("There is no subscription key".into()),
> > - serverid: Some(tools::get_hardware_address()?),
> > + serverid: tools::get_hardware_address().ok(),
> > url: Some(url.into()),
> > ..Default::default()
> > },
> > --
> > 2.20.1
> >
> >
> >
> > _______________________________________________
> > pbs-devel mailing list
> > pbs-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2020-11-10 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:59 Fabian Grünbichler
2020-11-10 16:01 ` Dietmar Maurer
2020-11-10 16:52 ` Fabian Grünbichler [this message]
2020-11-10 16:54 ` Thomas Lamprecht
2020-11-10 17:23 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=751610710.1048.1605027131503@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.