From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server 3/3] fix #7014: fix regression starting aarch64 VMs with machine type >= 10.1
Date: Wed, 12 Nov 2025 12:52:46 +0100 [thread overview]
Message-ID: <74b1b860-b474-46db-b017-7e9a67efa71b@proxmox.com> (raw)
In-Reply-To: <20251112112959.237909-4-f.ebner@proxmox.com>
Am 12.11.25 um 12:30 PM schrieb Fiona Ebner:
> diff --git a/src/PVE/QemuServer/Cfg2Cmd/Timer.pm b/src/PVE/QemuServer/Cfg2Cmd/Timer.pm
> index 452c15b2..d03715a0 100644
> --- a/src/PVE/QemuServer/Cfg2Cmd/Timer.pm
> +++ b/src/PVE/QemuServer/Cfg2Cmd/Timer.pm
> @@ -20,9 +20,9 @@ sub generate {
>
> if ($cfg2cmd->windows_version() >= 6) {
> $cfg2cmd->add_global_flag('kvm-pit.lost_tick_policy=discard');
> - $cfg2cmd->add_machine_flag('hpet=off');
> + $cfg2cmd->add_machine_flag_if_supported('hpet', 'off');
Turns out, it was actually a pre-existing issue for the Windows case
here even before the introduction of the Cfg2Cmd module, so these
patches do not only fix the regression, but that as well :) Shouldn't
have relied on pre-existing code to be correct :P
> } elsif ($cfg2cmd->is_linux() && $cfg2cmd->version_guard(10, 1, 0)) {
> - $cfg2cmd->add_machine_flag('hpet=off');
> + $cfg2cmd->add_machine_flag_if_supported('hpet', 'off');
> }
>
> $cfg2cmd->add_rtc_flag('driftfix=slew') if $time_drift_fix;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-12 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 11:29 [pve-devel] [PATCH-SERIES qemu-server 0/3] " Fiona Ebner
2025-11-12 11:29 ` [pve-devel] [PATCH qemu-server 1/3] machine: add machine_base_type() helper Fiona Ebner
2025-11-12 11:29 ` [pve-devel] [PATCH qemu-server 2/3] machine: add machine_supports_flag() helper Fiona Ebner
2025-11-12 11:29 ` [pve-devel] [PATCH qemu-server 3/3] fix #7014: fix regression starting aarch64 VMs with machine type >= 10.1 Fiona Ebner
2025-11-12 11:52 ` Fiona Ebner [this message]
2025-11-13 22:13 ` [pve-devel] applied: [PATCH-SERIES qemu-server 0/3] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b1b860-b474-46db-b017-7e9a67efa71b@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.