all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pdm-devel] applied: [PATCH proxmox-datacenter-manager] ui: do not mark the empty string as translatable
Date: Tue, 21 Jan 2025 15:00:17 +0100	[thread overview]
Message-ID: <74467e8e-fc58-4ba0-8d74-c57b5b7866f6@proxmox.com> (raw)
In-Reply-To: <20250121115446.260316-1-m.sandoval@proxmox.com>

Am 21.01.25 um 12:54 schrieb Maximiliano Sandoval:
> xtr will complain that there is a duplicated definition otherwise:
> 
>    proxmox-datacenter-manager.pot:185: duplicate message definition...
> 
> As per [1]:
> 
>> There is always one special message in each valid PO file: the PO file
>> header. It is encoded with the msgid for the empty string ("") as the
>> key, and the actual header values are in the msgstr part. This
>> unfortunately means that if you mark an empty string for translation,
>> you will get the entire PO file header back as the "translation". In
>> almost all cases this is probably not what you want. Hence, do not mark
>> empty strings for translation.
> 
> [1] https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Localize(20)using(20)gettext(20)and(20)intltool.html
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  ui/src/dashboard/subscription_info.rs | 2 +-
>  ui/src/remotes/wizard_page_info.rs    | 4 ++--
>  ui/src/widget/migrate_window.rs       | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      reply	other threads:[~2025-01-21 14:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 11:54 [pdm-devel] " Maximiliano Sandoval
2025-01-21 14:00 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74467e8e-fc58-4ba0-8d74-c57b5b7866f6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal