From: Lukas Wagner <l.wagner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH proxmox 1/2] notify: webhook: gotify: set Content-Length header
Date: Wed, 26 Mar 2025 10:54:46 +0100 [thread overview]
Message-ID: <74467ca7-5467-4f0f-879a-182bdb667a16@proxmox.com> (raw)
In-Reply-To: <804e5e3e-5cf0-4d50-8a5d-750342867527@proxmox.com>
On 2025-03-25 19:41, Thomas Lamprecht wrote:
> Am 21.03.25 um 10:56 schrieb Lukas Wagner:
>> To quote from RFC 9110 [1]:
>>
>> A user agent SHOULD send Content-Length in a request when
>> the method defines a meaning for enclosed content and it
>> is not sending Transfer-Encoding. For example, a user agent
>> normally sends Content-Length in a POST request even when
>> the value is 0 (indicating empty content).
>> A user agent SHOULD NOT send a Content-Length header field
>> when the request message does not contain content and the
>> method semantics do not anticipate such data.
>>
>> It seemed like our HTTP client lib did not set the header
>> automatically, which is why we should do it manually.
>>
>> While most services seemed to have worked fine without setting
>> the header, some Microsoft services seem to require it
>> to accept the webhook request [2].
>>
>> [1] https://datatracker.ietf.org/doc/html/rfc9110#name-content-length
>> [2] https://forum.proxmox.com/threads/158827
>>
>> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
>> ---
>> proxmox-notify/src/endpoints/gotify.rs | 4 ++++
>> proxmox-notify/src/endpoints/webhook.rs | 19 ++++++++++++++++++-
>> 2 files changed, 22 insertions(+), 1 deletion(-)
>>
>>
>
> applied both patches, thanks!
>
> FWIW, as it was already encoded in the commit message for posterity I'd
> have been fine with the comment being a bit shorter, e.g., the link to
> the RFC and the last line, but it did not bother me to care amending the
> patch and it's not a clear-cut, or at least subjective, so just a nit.
The brief quote from the RFC gives good context on *why* the change should be done
in a self-contained way without having to go to the RFC text and search for the correct
paragraph. IMO it definitely makes sense to have it in the commit message.
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-26 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 9:56 [pve-devel] " Lukas Wagner
2025-03-21 9:57 ` [pve-devel] [PATCH proxmox 2/2] notify: gotify: use constant from http crate for 'Authorization' header Lukas Wagner
2025-03-25 18:41 ` [pve-devel] applied: [PATCH proxmox 1/2] notify: webhook: gotify: set Content-Length header Thomas Lamprecht
2025-03-26 9:54 ` Lukas Wagner [this message]
2025-03-26 10:11 ` Thomas Lamprecht
2025-03-26 10:20 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74467ca7-5467-4f0f-879a-182bdb667a16@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.