From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] fix #3302: allow more characters for email
Date: Thu, 8 Apr 2021 10:07:17 +0200 (CEST) [thread overview]
Message-ID: <740035669.1343.1617869237658@webmail.proxmox.com> (raw)
Please can we define a pub const regex, so that we can use it in the API?
> On 04/08/2021 8:01 AM Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>
> any comment? we should really allow at least
> '_' and '+' in addition
>
> On 2/12/21 9:40 AM, Dominik Csapak wrote:
> > change to something similar as in pve-common
> > word characters, +, -, ~ and . for the local part
> >
> > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> > ---
> > proxmox/src/tools/email.rs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/proxmox/src/tools/email.rs b/proxmox/src/tools/email.rs
> > index b5d42c4..c6336f4 100644
> > --- a/proxmox/src/tools/email.rs
> > +++ b/proxmox/src/tools/email.rs
> > @@ -16,7 +16,7 @@ pub fn sendmail(
> > mailfrom: Option<&str>,
> > author: Option<&str>,
> > ) -> Result<(), Error> {
> > - let mail_regex = regex::Regex::new(r"^[a-zA-Z\.0-9-]+@[a-zA-Z\.0-9-]+$").unwrap();
> > + let mail_regex = regex::Regex::new(r"^[\w\+\-\~\.]+@[a-zA-Z\.0-9-]+$").unwrap();
> >
> > if mailto.is_empty() {
> > bail!("At least one recipient has to be specified!")
> >
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2021-04-08 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 8:07 Dietmar Maurer [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-12 8:40 Dominik Csapak
2021-04-08 6:01 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=740035669.1343.1617869237658@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.