Re: [PATCH qemu-server v2 4/4] qga: rename guest-fsfreeze to freeze-fs

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 26.03.26 um 10:07 schrieb Maximiliano Sandoval:
> Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
> 
>> These settings are already in the (QEMU guest) agent property, and we
>> do not use the guest- prefix for any of the existing properties
>> (fstrim or freeze-fs-on-backup), and moving freeze-fs-on-backup to a
>> generic variant is less confusing if one just drops the "-on-backup"
>> part, i.e. no point in inventing a new name schema just for the sake
>> of it.
>>
>> We already rolled this the guest-fsfreeze name to pve-test, so lets
>> add an alias, but as we do not provide API stability guarantees for
>> test packages this is really just for convenience for anybody that
>> tested this, I'm more than fine with dropping such a (never stable)
>> released key again on a major release with the respective upgrade
>> check in our pveXtoY tool.
>>
>> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> For the sake of documenting, the rationale behind the "guest-fsfreeze"
> name was using the guest agent command names, namely
> "guest-fsfreeze-freeze" and "guest-fsfreeze-thaw", as a base.

I got that, but the specific low-level QMP QGA commands are a
implementation detail, leaking that is IMO not the best way to reduce
any confusion, which IMO is rather unlikely to affect end users much,
as those don't really care what the underlying commands are named after.

> For a long time I struggled to find the actual name of these commands
> and their documentation since they are named ever-so-slightly
> differently each time they appear on the docs or UI: "fsfreeze",
> "freeze", "fs-freeze", etc.

If, then this makes it sound like the documentation should improve, if
this is really something our users struggle with too - which I'd find
slightly surprising, tbh.

> If anything, I personally found the old name to be a source of confusion.

For what exactly? And wouldn't we then have to encode both, the freeze
and thaw also in the name? Like guest-fsfreeze-freeze-and-thaw?