all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [PATCH qemu] Fix dirty-bitmap PBS backup with multiple drives
Date: Tue, 14 Jul 2020 11:04:46 +0200	[thread overview]
Message-ID: <73286077-898e-8d55-2d76-4e30a7a68a62@proxmox.com> (raw)
In-Reply-To: <20200714084516.6321-1-s.reiter@proxmox.com>

On 14.07.20 10:45, Stefan Reiter wrote:
> "PVE backup: rename incremental to use-dirty-bitmap" merged two
> variables (use_dirty_bitmap and incremental) into one, but they served
> two different purposes. Rename the original use_dirty_bitmap to
> "expect_only_dirty" so the new one doesn't conflict, and rework "PVE:
> use proxmox_backup_check_incremental" around that semantic.
> 
> In practice, this had the effect that only one disk at a time would
> have a bitmap added, as after the first "use_dirty_bitmap" would be set
> to one and the rest would behave as if the QMP parameter of the same
> name was unset.
> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> 
> I changed it in the original patches to avoid a fixup on top of fixups, hope
> that's good.
> 
>  ...name-incremental-to-use-dirty-bitmap.patch | 27 ++++++++--------
>  ...irty-counter-for-non-incremental-bac.patch |  6 ++--
>  ...use-proxmox_backup_check_incremental.patch | 31 ++++++++-----------
>  3 files changed, 30 insertions(+), 34 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2020-07-14  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14  8:45 [pbs-devel] " Stefan Reiter
2020-07-14  9:04 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73286077-898e-8d55-2d76-4e30a7a68a62@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.reiter@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal