* [pbs-devel] [PATCH proxmox-backup] ui: fix local sync job edit
@ 2023-11-28 13:01 Hannes Laimer
2023-11-28 13:02 ` Lukas Wagner
2023-11-28 13:13 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Laimer @ 2023-11-28 13:01 UTC (permalink / raw)
To: pbs-devel
... since the store field was cleared when the window opened.
Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Fixes: 9039d6709e375f37bb8a21680f6fefb18ee87ab3
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
the fie
www/form/RemoteTargetSelector.js | 4 ++--
www/window/SyncJobEdit.js | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/form/RemoteTargetSelector.js b/www/form/RemoteTargetSelector.js
index 9ea802d1..3d066f54 100644
--- a/www/form/RemoteTargetSelector.js
+++ b/www/form/RemoteTargetSelector.js
@@ -33,10 +33,10 @@ Ext.define('PBS.form.RemoteStoreSelector', {
// do nothing.
},
- setRemote: function(remote) {
+ setRemote: function(remote, forceReload = false) {
let me = this;
- if (me.remote === remote) {
+ if (!forceReload && me.remote === remote) {
return;
}
diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index dbd53178..d20def74 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -181,15 +181,15 @@ Ext.define('PBS.window.SyncJobEdit', {
remoteField.setDisabled(isLocalSync);
storeField.setDisabled(!isLocalSync && !remoteField.value);
if (isLocalSync === !!remoteField.value) {
- storeField.clearValue();
remoteField.clearValue();
}
if (isLocalSync) {
storeField.setDisabled(false);
rateLimitField.setValue(null);
- storeField.setRemote(null);
+ storeField.setRemote(null, true);
} else {
+ storeField.clearValue();
remoteField.validate();
}
},
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] ui: fix local sync job edit
2023-11-28 13:01 [pbs-devel] [PATCH proxmox-backup] ui: fix local sync job edit Hannes Laimer
@ 2023-11-28 13:02 ` Lukas Wagner
2023-11-28 13:13 ` [pbs-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2023-11-28 13:02 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Hannes Laimer
On 11/28/23 14:01, Hannes Laimer wrote:
> ... since the store field was cleared when the window opened.
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Fixes: 9039d6709e375f37bb8a21680f6fefb18ee87ab3
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
Can confirm that this patch resolves the issue:
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
--
- Lukas
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] ui: fix local sync job edit
2023-11-28 13:01 [pbs-devel] [PATCH proxmox-backup] ui: fix local sync job edit Hannes Laimer
2023-11-28 13:02 ` Lukas Wagner
@ 2023-11-28 13:13 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-11-28 13:13 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Hannes Laimer
Am 28/11/2023 um 14:01 schrieb Hannes Laimer:
> ... since the store field was cleared when the window opened.
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Fixes: 9039d6709e375f37bb8a21680f6fefb18ee87ab3
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> the fie
>
> www/form/RemoteTargetSelector.js | 4 ++--
> www/window/SyncJobEdit.js | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-28 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-28 13:01 [pbs-devel] [PATCH proxmox-backup] ui: fix local sync job edit Hannes Laimer
2023-11-28 13:02 ` Lukas Wagner
2023-11-28 13:13 ` [pbs-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal