Re: [pve-devel] [PATCH pve-storage 1/2] plugin: map/activate volume: allow callers to pass hints

From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Friedrich Weber <f.weber@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage 1/2] plugin: map/activate volume: allow callers to pass hints
Date: Tue, 28 Oct 2025 13:17:42 +0100	[thread overview]
Message-ID: <7250f495-0892-44c9-9c20-90ef937527d6@proxmox.com> (raw)
In-Reply-To: <20251024122705.93761-2-f.weber@proxmox.com>

Am 24.10.25 um 2:27 PM schrieb Friedrich Weber:
> +sub verify_hints {
> +    my ($hints, $noerr) = @_;
> +
> +    return if !defined($hints);
> +
> +    eval { PVE::JSONSchema::validate($hints, $PVE::Storage::Plugin::hints_format); };
> +    my $err = $@;
> +
> +    return $hints if !$err;
> +    return if $noerr;
> +
> +    die "hints are not valid: $@";
Nit: I'd use "internal error - storage hints ..." to reduce potential
for confusion.

> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 8acd214..2c72179 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -59,6 +59,19 @@ cfs_register_file(
>      sub { __PACKAGE__->write_config(@_); },
>  );
>  
> +our $hints_properties = {
> +    'guest-ostype' => {
> +        type => 'string',
> +        optional => 1,
> +    },

I'd rather have this be an explicit "guest-is-windows" boolean. The
storage layer should not have any idea of how to parse guest OS types.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel