From: Nicolas Frey <n.frey@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new'
Date: Tue, 20 Jan 2026 14:24:24 +0100 [thread overview]
Message-ID: <72072299-6e64-4e12-9c4b-28d7c41d2a63@proxmox.com> (raw)
In-Reply-To: <20260120113351.22921-1-h.laimer@proxmox.com>
missed this when I added datastore-level thread settings, thanks!
Reviewed-by: Nicolas Frey <n.frey@proxmox.com>
On 1/20/26 12:33 PM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> src/api2/backup/environment.rs | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs
> index bd9c5211..3c624b18 100644
> --- a/src/api2/backup/environment.rs
> +++ b/src/api2/backup/environment.rs
> @@ -799,10 +799,13 @@ impl BackupEnvironment {
> false,
> move |worker| {
> worker.log_message("Automatically verifying newly added snapshot");
> -
> - // FIXME: update once per-datastore read/verify settings
> - // are available to not use default amount of threads here
> - let verify_worker = VerifyWorker::new(worker.clone(), datastore, None, None)?;
> + let thread_settings = datastore.thread_settings().clone();
> + let verify_worker = VerifyWorker::new(
> + worker.clone(),
> + datastore,
> + thread_settings.verify_job_read_threads,
> + thread_settings.verify_job_verify_threads,
> + )?;
> if !verify_worker.verify_backup_dir_with_lock(
> &backup_dir,
> worker.upid().clone(),
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2026-01-20 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 11:33 Hannes Laimer
2026-01-20 13:24 ` Nicolas Frey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72072299-6e64-4e12-9c4b-28d7c41d2a63@proxmox.com \
--to=n.frey@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.