From: Leo Nunner <l.nunner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH storage manager docs] Allow mounting of CIFS subdirectories
Date: Thu, 2 Feb 2023 15:20:54 +0100 [thread overview]
Message-ID: <71e16b47-d5c2-cdbc-c97a-eb332c4a7a09@proxmox.com> (raw)
In-Reply-To: <20221201113257.57225-1-l.nunner@proxmox.com>
On 2022-12-01 12:32, Leo Nunner wrote:
> CIFS supports mounting subdirectories inside a share, so it makes sense
> to also have the 'subdir' parameter for the CIFS backend. I'm also
> looking into allowing overrides for all the fixed directories, but
> even then, I think it makes sense to support this parameter (for either
> providing a prefix to all the other directories, or just changing the
> base directory).
>
> storage:
>
> Leo Nunner (1):
> fix #2641: allow mounting of CIFS subdirectories
>
> PVE/Storage/CIFSPlugin.pm | 39 ++++++++++++++++++++-----------------
> PVE/Storage/CephFSPlugin.pm | 4 ----
> PVE/Storage/Plugin.pm | 5 +++++
> 3 files changed, 26 insertions(+), 22 deletions(-)
>
> manager:
>
> Leo Nunner (1):
> fix #2641: expose CIFS subdir parameter through GUI
>
> www/manager6/storage/CIFSEdit.js | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> docs:
>
> Leo Nunner (1):
> fix #2641: document subdir parameter for CIFS backend
>
> pve-storage-cifs.adoc | 5 +++++
> 1 file changed, 5 insertions(+)
Bump due to continued user demand. storage and manager seem to still
apply, while docs produces a merge conflict because it clashes with the
"content-dirs" documentation. Does this warrant a v2?
next prev parent reply other threads:[~2023-02-02 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 11:32 Leo Nunner
2022-12-01 11:32 ` [pve-devel] [PATCH storage 1/1] fix #2641: allow " Leo Nunner
2023-02-07 14:58 ` [pve-devel] applied: " Thomas Lamprecht
2022-12-01 11:32 ` [pve-devel] [PATCH manager 1/1] fix #2641: expose CIFS subdir parameter through GUI Leo Nunner
2022-12-01 11:32 ` [pve-devel] [PATCH docs 1/1] fix #2641: document subdir parameter for CIFS backend Leo Nunner
2023-02-02 14:20 ` Leo Nunner [this message]
2023-02-07 14:58 ` [pve-devel] applied: [PATCH storage manager docs] Allow mounting of CIFS subdirectories Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71e16b47-d5c2-cdbc-c97a-eb332c4a7a09@proxmox.com \
--to=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal