Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path

[Aaron Lauterer <a.lauterer@proxmox.com>]

On 4/11/22 14:17, Thomas Lamprecht wrote:
[...]
>>
>> Some more (smaller) changes might be necessary, if the implementation we
>> manage to upstream will be a bit different. But that should not be much of an
>> issue AFAICT.
> 
> We can always ship our downstream solution to be whatever we want and sync up
> on major release, so not a real problem.
> 
> FWIW, with storage getting the following patch the symlinks get created (may need
> an trigger for reloading udev (or manually `udevadm control -R`).
> 
> We'd only need to check to prioritize /deb/rbd-pve/$fsid/... paths first;
> do you have time to give that a go?


The final `fi` in the renamer script was missing from the diff. Once I fixed that, it seems to work fine. Situation with a local hyperconverged cluster and an external one:
---------------------------------
root@cephtest1:/dev/rbd-pve# tree
.
├── ce99d398-91ab-4667-b4f2-307ba0bec358
│   └── ecpool-metadata
│       ├── vm-103-disk-0 -> ../../../rbd0
│       ├── vm-103-disk-0-part1 -> ../../../rbd0p1
│       ├── vm-103-disk-0-part2 -> ../../../rbd0p2
│       ├── vm-103-disk-0-part5 -> ../../../rbd0p5
│       ├── vm-103-disk-1 -> ../../../rbd1
│       └── vm-103-disk-2 -> ../../../rbd2
└── e78d9b15-d5a1-4660-a4a5-d2c1208119e9
     └── rbd
         └── vm-103-disk-0 -> ../../../rbd3