From: Friedrich Weber <f.weber@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 0/2] fix #4997: lvm: avoid autoactivating (new) LVs after boot
Date: Fri, 7 Mar 2025 11:09:12 +0100 [thread overview]
Message-ID: <71713e88-61d9-4b40-86b3-8580d4935a07@proxmox.com> (raw)
In-Reply-To: <1739184319.tj66c5n2zq.astroid@yuna.none>
sent a v2:
https://lore.proxmox.com/pve-devel/20250307095245.65698-1-f.weber@proxmox.com/T/
On 10/02/2025 11:47, Fabian Grünbichler wrote:
> [...]
>
>>
>> So I'm wondering:
>>
>> (a) could the ZFS initramfs script use `-aay` instead of `-ay`, so the
>> `--setautoactivation` flag has an effect again for LVs that are visible
>> at boot?
>
> probably ;)
v2 contains a zfsonlinux patch for this, I'll also send it upstream.
>>
>> (b) assuming (a) can be fixed, is there any additional reason to prefer
>> to --ignoreactivationskip/--setactivationskip approach over the
>> `--setautoactivation n` approach?
>
> the only other reason I could think of is that there's a metric ton of
> tutorials/howtos for various things that contain "vgchange -ay" which
> would still entail potential breakage.. but then again, one could argue
> that people blindly following such instructions are to blame, and the
> reduced complexity on our end would be worth it..
Good point, though I'd hope users would run `vgchange -ay` only
occasionally, triggering the issue for the current boot only but not for
every subsequent boot. The v2 would probably still need to wait until
PVE 9 (see its cover letter for details), so not much gained here in
comparison to v1. I still find its approach less complex and would
prefer it, but this is of course debatable :)
>>
>> [1]
>> https://github.com/openzfs/zfs/blob/c2458ba921a8d59cd6b705f81b37f50531f8670b/contrib/initramfs/scripts/local-top/zfs
>>
>> [2] FWIW, one way to debug this:
>>
>> - attaching a serial console to the VM
>> - removing `quiet` and adding `console=ttyS0` to the kernel command line
>> - setting `log_level=debug` in
>> /usr/share/initramfs-tools/scripts/init-top/udev
>> - adding some debug printouts (echo XYZ > /dev/ttyS0) to
>> /usr/share/initramfs-tools/scripts/local-top/zfs
>> - don't forget `update-initramfs -u`
>> - attach to serial console on host: `qm console VMID`
>>
>>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-07 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 15:03 Friedrich Weber
2024-01-11 15:03 ` [pve-devel] [PATCH storage 1/2] lvm: ignore "activation skip" LV flag during LV activation Friedrich Weber
2024-01-26 11:14 ` Fiona Ebner
2024-01-11 15:03 ` [pve-devel] [PATCH storage 2/2] fix #4997: lvm: set "activation skip" flag for newly created LVs Friedrich Weber
2024-01-26 11:15 ` Fiona Ebner
2024-01-26 11:14 ` [pve-devel] [PATCH storage 0/2] fix #4997: lvm: avoid autoactivating (new) LVs after boot Fiona Ebner
2024-01-31 15:07 ` Friedrich Weber
2024-02-01 8:26 ` Fiona Ebner
2025-02-07 13:12 ` Friedrich Weber
2025-02-07 12:44 ` Friedrich Weber
2025-02-10 10:47 ` Fabian Grünbichler
2025-03-07 10:09 ` Friedrich Weber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71713e88-61d9-4b40-86b3-8580d4935a07@proxmox.com \
--to=f.weber@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.