all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-cluster] pve-cluster.service : remove 127.0.1.1 from /etc/hosts
Date: Wed, 28 Jun 2023 09:28:50 +0200	[thread overview]
Message-ID: <6fd43966-6917-3cb4-e7dd-53cbae3b3ce2@proxmox.com> (raw)
In-Reply-To: <20230628060628.502358-1-aderumier@odiso.com>

Am 28/06/2023 um 08:06 schrieb Alexandre Derumier:
> stock debian or some hosting company like ovh through cloudinit at each boot,
> add 127.0.1.1 <hostname> in /etc/hosts.

Yeah, tools just messing with /etc/hosts et al. is irritating..

> 
> This is breaking pve-cluster start.
> 
> fix:
> https://forum.proxmox.com/threads/proxmox-7-to-8-upgrade-problem-ovh.129678/
> https://forum.proxmox.com/threads/update-7-to-8-issue-with-cloud-init.129669/#post-568172
> https://forum.proxmox.com/threads/bookworm-installation-fails-with-pve-manager-dependency-error.129398/#post-568290
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  debian/pve-cluster.service | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/pve-cluster.service b/debian/pve-cluster.service
> index 4327055..f6bdac2 100644
> --- a/debian/pve-cluster.service
> +++ b/debian/pve-cluster.service
> @@ -14,6 +14,7 @@ Before=shutdown.target
>  Conflicts=shutdown.target
>  
>  [Service]
> +ExecStartPre=/usr/bin/sed -i '/127.0.1.1/d' /etc/hosts

.. and so is this, messing with hosts on every  pve-cluster start or update..

So no, please don't, messing with such things can be really subtle!

Let's rather improve pmxcfs logic for getting the non-local IP configured on
a node via getaddrinfo with the ALL flag and filtering out local IPs..

>  ExecStart=/usr/bin/pmxcfs
>  KillMode=mixed
>  Restart=on-failure





  reply	other threads:[~2023-06-28  7:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  6:06 Alexandre Derumier
2023-06-28  7:28 ` Thomas Lamprecht [this message]
2023-06-28  7:47   ` DERUMIER, Alexandre
2023-06-28  8:13     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fd43966-6917-3cb4-e7dd-53cbae3b3ce2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal