all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer 0/5] allow both snake- and kebab-cased property names in the answer file
Date: Mon, 24 Feb 2025 13:05:41 +0100	[thread overview]
Message-ID: <6edf92f2-8262-4eb7-96f1-d6a09f0c9866@proxmox.com> (raw)
In-Reply-To: <20250217121748.117222-1-d.kral@proxmox.com>

Am 17.02.25 um 13:17 schrieb Daniel Kral:
> This is a followup to a previous discussion at [0].
> 
> Small patch series which allows both snake- and kebab-cased property
> names in the configuration file for the auto installer, i.e. answer
> files. This allows to introduce a migration from snake_cased towards
> kebab-cased property names in the answer file to be consistent with
> other configuration files, which prefer kebab-case too.
> 
> The only property key that was not changed in casing was the filter
> match rules for network and block devices as those are not in our
> control, but matches the udevadm output's JSON property keys (e.g.
> "filter.ID_MODEL").
> 
> The last patch introduces a deprecation warning that is output to the
> user when verifying answer files and preparing auto installer ISOs with
> the assistant to be applied for a major version bump, i.e. PVE
> 9.0/Trixie-based releases as suggested by @Thomas at [0].
> 
> [0] https://lore.proxmox.com/pve-devel/0dec173a-da75-4d70-ac07-e1133c136081@proxmox.com/
> 
> Daniel Kral (5):
>   auto-installer: factor out field rename casing for network config mode
>   auto-installer: first-boot: allow snake- and kebabcased property names
>   auto-installer: allow snake- and kebabcased property names in answer
>     files
>   auto-installer: add redundant kebab-case renames to config structures
>   assistant: add deprecation notice for snakecased parameters
> 
>  proxmox-auto-install-assistant/src/main.rs | 24 ++++++++++++++++
>  proxmox-auto-installer/src/answer.rs       | 33 +++++++++++++---------
>  2 files changed, 44 insertions(+), 13 deletions(-)
> 


applied series, thanks!

But shortly discussed off-list I squashed the commits into a single one.
As while I get how you separate it, and I'm generally in favor of not
squashing every that looks similar into the same commit, this here is
basically a single semantic change where one has a better git log "reading
flow" if one sees the full change all in a single commit.

Just for the sake of completeness: If in doubt, I'd almost always favor
having the commits split over squashed, as squashing is normally a very
quick operation; so it was IMO definitively also an OK call to send this
series the way you did.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-02-24 12:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 12:17 [pve-devel] " Daniel Kral
2025-02-17 12:17 ` [pve-devel] [PATCH installer 1/5] auto-installer: factor out field rename casing for network config mode Daniel Kral
2025-02-17 12:17 ` [pve-devel] [PATCH installer 2/5] auto-installer: first-boot: allow snake- and kebabcased property names Daniel Kral
2025-02-17 12:17 ` [pve-devel] [PATCH installer 3/5] auto-installer: allow snake- and kebabcased property names in answer files Daniel Kral
2025-02-17 12:17 ` [pve-devel] [PATCH installer 4/5] auto-installer: add redundant kebab-case renames to config structures Daniel Kral
2025-02-17 12:17 ` [pve-devel] [PATCH for-PVE-9.0/installer 5/5] assistant: add deprecation notice for snakecased parameters Daniel Kral
2025-02-24 12:05 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6edf92f2-8262-4eb7-96f1-d6a09f0c9866@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal