* [pve-devel] [PATCH ha-manager 1/2] test: ha tester: drop unused import
@ 2025-01-22 10:55 Fiona Ebner
2025-01-22 10:55 ` [pve-devel] [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace Fiona Ebner
2025-01-22 16:05 ` [pve-devel] applied: [PATCH ha-manager 1/2] test: ha tester: drop unused import Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Fiona Ebner @ 2025-01-22 10:55 UTC (permalink / raw)
To: pve-devel
There is no user of File::Path remaining after commit 787b66e
("SimCluster: setup status dir inside new") which was the only user
of remove_tree(). make_path() was not used at all according to git
history.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/test/ha-tester.pl | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/test/ha-tester.pl b/src/test/ha-tester.pl
index 8b73a58..8ff1629 100755
--- a/src/test/ha-tester.pl
+++ b/src/test/ha-tester.pl
@@ -4,8 +4,6 @@ use strict;
use warnings;
use Getopt::Long;
-use File::Path qw(make_path remove_tree);
-
my $opt_nodiff;
my $opt_nofail;
my $opt_notestout;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace
2025-01-22 10:55 [pve-devel] [PATCH ha-manager 1/2] test: ha tester: drop unused import Fiona Ebner
@ 2025-01-22 10:55 ` Fiona Ebner
2025-01-22 16:05 ` [pve-devel] applied: " Thomas Lamprecht
2025-01-22 16:05 ` [pve-devel] applied: [PATCH ha-manager 1/2] test: ha tester: drop unused import Thomas Lamprecht
1 sibling, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2025-01-22 10:55 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/test/ha-tester.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/ha-tester.pl b/src/test/ha-tester.pl
index 8ff1629..0693133 100755
--- a/src/test/ha-tester.pl
+++ b/src/test/ha-tester.pl
@@ -47,7 +47,7 @@ sub do_run_test {
my $logexpect = "$dir/log.expect";
if (-f $logexpect) {
- my $cmd = ['diff', '-u', $logexpect, $logfile];
+ my $cmd = ['diff', '-u', $logexpect, $logfile];
$res = system(@$cmd);
return "test '$dir' failed\n" if $res != 0;
} else {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH ha-manager 1/2] test: ha tester: drop unused import
2025-01-22 10:55 [pve-devel] [PATCH ha-manager 1/2] test: ha tester: drop unused import Fiona Ebner
2025-01-22 10:55 ` [pve-devel] [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace Fiona Ebner
@ 2025-01-22 16:05 ` Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-01-22 16:05 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 22.01.25 um 11:55 schrieb Fiona Ebner:
> There is no user of File::Path remaining after commit 787b66e
> ("SimCluster: setup status dir inside new") which was the only user
> of remove_tree(). make_path() was not used at all according to git
> history.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/test/ha-tester.pl | 2 --
> 1 file changed, 2 deletions(-)
>
>
applied, thanks!
I followed-up with another commit that does the same for the fence config
test script.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace
2025-01-22 10:55 ` [pve-devel] [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace Fiona Ebner
@ 2025-01-22 16:05 ` Thomas Lamprecht
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-01-22 16:05 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 22.01.25 um 11:55 schrieb Fiona Ebner:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/test/ha-tester.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-22 16:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-22 10:55 [pve-devel] [PATCH ha-manager 1/2] test: ha tester: drop unused import Fiona Ebner
2025-01-22 10:55 ` [pve-devel] [PATCH ha-manager 2/2] test: ha tester: remove trailing whitespace Fiona Ebner
2025-01-22 16:05 ` [pve-devel] applied: " Thomas Lamprecht
2025-01-22 16:05 ` [pve-devel] applied: [PATCH ha-manager 1/2] test: ha tester: drop unused import Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal