Re: [pve-devel] [PATCH manager v2 0/6] fix #1408: ui: make tree sorting configurable

[Aaron Lauterer <a.lauterer@proxmox.com>]

Had two small nits in patch 5/6. Otherwise it seems to work nicely. Tested all 
options and also had tags with tag overrides configured in my tests.

Consider this

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On 2/2/23 15:41, Dominik Csapak wrote:
> this series allows configuring the sorting of the resource tree
> 
> options are the sort-field, if guest types are grouped and if templates
> are grouped seperately. it's configurable via browser local storage
> 
> the first 2 patches are not really related but popped up during
> development
> 
> changes from v1:
> * drop the datacenter config options for now
> * rename TreeSortingEdit into TreeSortingEdit
> * since we don't have a fallback besides the default, display the
>    defauls in the dropdowns
> * don't use booleanfield anymore (because of above change)
> * rename sp into localStorage
> * use fieldDefaults
> * refactor stuff into PVE.UIOptions (a new singleton)
> * remove storage view
> * remove booleanfield
> 
> Dominik Csapak (6):
>    ui: remove 'Storage View'
>    ui: remove unused booleanfield
>    ui: refactor ui option related methods into UIOptions
>    ui: refactor refreshing the the resource store/tree
>    ui: add window for changing tree related options
>    fix #1408: ui: ResourceTree: sort the tree according to tree-sorting
>      options
> 
>   www/manager6/Makefile                   |   3 +-
>   www/manager6/UIOptions.js               | 107 ++++++++++++++++++++++++
>   www/manager6/Utils.js                   |  92 +-------------------
>   www/manager6/Workspace.js               |  28 ++++++-
>   www/manager6/data/ResourceStore.js      |   2 +-
>   www/manager6/dc/OptionView.js           |  23 ++---
>   www/manager6/form/Boolean.js            |  10 ---
>   www/manager6/form/GlobalSearchField.js  |   2 +-
>   www/manager6/form/Tag.js                |   6 +-
>   www/manager6/form/TagColorGrid.js       |   2 +-
>   www/manager6/form/TagEdit.js            |  10 +--
>   www/manager6/form/ViewSelector.js       |   7 --
>   www/manager6/tree/ResourceTree.js       |  56 ++++++++++---
>   www/manager6/window/TreeSettingsEdit.js |  87 +++++++++++++++++++
>   14 files changed, 289 insertions(+), 146 deletions(-)
>   create mode 100644 www/manager6/UIOptions.js
>   delete mode 100644 www/manager6/form/Boolean.js
>   create mode 100644 www/manager6/window/TreeSettingsEdit.js
>