all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH qemu-server 1/2] vzdump: tpmstate: escape drive string
Date: Fri, 16 Sep 2022 12:54:52 +0200	[thread overview]
Message-ID: <6e331d38-1523-7ea7-e3f0-afb98e7c1095@proxmox.com> (raw)
In-Reply-To: <20220914130728.1520282-1-f.gruenbichler@proxmox.com>

Am 14/09/2022 um 15:07 schrieb Fabian Grünbichler:
> the volume path could contain escaped ":" or ",", which means their '\'
> needs to be escaped another time for passing to HMP.
> 
> the same approach is used for hotplugging regular drives in
> PVE::QemuServer, and is needed (at least) for RBD storages with IPv6
> monhosts or an explicit monhost port.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     reported and fix tested by Tuxis in our forum:
>     
>     https://forum.proxmox.com/threads/pbs-backup-attaching-tpm-drive-failed.114996
> 
>  PVE/VZDump/QemuServer.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied both patches, thanks!




      parent reply	other threads:[~2022-09-16 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 13:07 [pve-devel] " Fabian Grünbichler
2022-09-14 13:07 ` [pve-devel] [PATCH qemu-server 2/2] vzdump: tpmstate: include HMP error in message Fabian Grünbichler
2022-09-16 10:54 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e331d38-1523-7ea7-e3f0-afb98e7c1095@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal