From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager v3 0/3] ui: prompt users for reload when web ui version changes
Date: Thu, 19 Nov 2026 23:21:48 +0100 [thread overview]
Message-ID: <6e0ab02a-bef6-45a3-84dd-239f4eeb4c8c@proxmox.com> (raw)
In-Reply-To: <20261119171151.475428-1-d.csapak@proxmox.com>
Am 19.11.26 um 18:12 schrieb Dominik Csapak:
> On some updates (like recently with ceph), the UI has new or better
> information about backend states, but the user must reload the page to
> get the new version, which might not be obvious.
>
> To help users detect such outdated running UI versions, send the current
> one in the index and /cluster/resources api call for the node that
> the browser is connected to. The ui can then compare these and prompt
> the user to reload.
thanks, can be nice to have, a few points on the design:
1. Popping up a modal dialog for this is a bit bold ;-) and with
`closable: false` on top it's a good way to drive people up the wall.
Imagine you're setting up a backup job with a complex selection, and then
the UI throws a dialog at you that you can't just close and that pushes
you towards a reload, which would throw all that state away. An outdated
UI is rarely that urgent. FWIW, where I needed something like this
elsewhere, I went with a non-modal snack bar only, similar to Home
Assistant, because a UI that forces me to reload (and lose my state) is
one of the things that rather annoy me.
2. After "Later", the sentence plus button in the top bar push the user menu
off screen in a 1280 px wide window, even more so with longer
translations.
3. Instead of the dialog and that hint, I'd rather show a small notice right
after the version string: an info icon, a short "New version" label and
a compact "Reload UI" button, with a tooltip on both like "A new version
of the web interface was installed. Reload the page to use it." That
also fits at 1280 px with longer translations.
4. I'd keep this out of /cluster/resources. It's polled every few seconds
and used by many other clients, the new property is only set for one
node, and it adds a column to `pvesh get /cluster/resources`. The ticket
call is not a good fit either, it lives in pve-access-control and every
API client logging in would get this.
GET /nodes/{node}/version seems like the right place: it already returns
the pve-manager version, every user may call it, and it's proxied to the
given node, so the answer always comes from the node the page was loaded
from, even behind a load balancer. The UI can check it every few
minutes, a short delay after an upgrade is fine. Please ignore errors
there though, the check will hit the pveproxy restart during the upgrade
and would otherwise pop up an error dialog.
Smaller ones/nits: I'd rename GUIVersions to UIVersion and make it a single
string, built by one helper from the pve-manager and widget toolkit versions
and used for both the index and an optional `ui-version` property of the
version call. The UI only needs to know whether anything changed, and
sharing the helper rules out format mismatches.
Patch 1/3 is fine as is. I tried a few notice variants in a mock setup and
can send you screenshots if that helps.
prev parent reply other threads:[~2026-11-19 22:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:09 [PATCH pve-manager v3 0/3] ui: prompt users for reload when web ui version changes Dominik Csapak
2026-11-19 17:09 ` [PATCH pve-manager v3 1/3] api: factor out read_pwt_version and pwt_base_dir Dominik Csapak
2026-11-19 17:09 ` [PATCH pve-manager v3 2/3] api: provide GUI versions via index and /cluster/resources Dominik Csapak
2026-11-19 17:09 ` [PATCH pve-manager v3 3/3] ui: workspace: prompt user for reload when UI packages were updated Dominik Csapak
2026-11-19 22:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0ab02a-bef6-45a3-84dd-239f4eeb4c8c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.