all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v3 0/3] ui: prompt users for reload when web ui version changes
Date: Thu, 19 Nov 2026 18:09:06 +0100	[thread overview]
Message-ID: <20261119171151.475428-1-d.csapak@proxmox.com> (raw)

On some updates (like recently with ceph), the UI has new or better
information about backend states, but the user must reload the page to
get the new version, which might not be obvious.

To help users detect such outdated running UI versions, send the current
one in the index and /cluster/resources api call for the node that
the browser is connected to. The ui can then compare these and prompt
the user to reload.

changes from v2:
* always use mtime to check if we should read the file again, this
  is cheap enough and more accurate

  i measured a stat call on the file with a simple loop of 1000000
  calls, and it came out to ~3.5s on my machine, this would make
  one stat call cost abou 3us which is fine IMO.
  (though my benchmark methodology is probably a bit flawed...)

changes from v1:
* move the caching of the pwt version from the /cluster/resources API
  call into read_pwt_version, so all callers share it
* add a 'force' parameter to read_pwt_version and use it for the index,
  so that the index always gets the current version, like before
* don't focus any button by default in the reload message box, so an
  accidental key press neither reloads nor dismisses it
* mention in the commit message that the prompt can lag behind one poll
  cycle
* sort the 'use PVE::File' statement correctly

Dominik Csapak (3):
  api: factor out read_pwt_version and pwt_base_dir
  api: provide GUI versions via index and /cluster/resources
  ui: workspace: prompt user for reload when UI packages were updated

 PVE/API2/Cluster.pm       | 31 ++++++++++++++++++
 PVE/API2Tools.pm          | 27 ++++++++++++++++
 PVE/Service/pveproxy.pm   |  6 ++--
 www/index.html.tpl        |  6 +++-
 www/manager6/Workspace.js | 67 +++++++++++++++++++++++++++++++++++++++
 5 files changed, 133 insertions(+), 4 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-11-19 17:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 17:09 Dominik Csapak [this message]
2026-11-19 17:09 ` [PATCH pve-manager v3 1/3] api: factor out read_pwt_version and pwt_base_dir Dominik Csapak
2026-11-19 17:09 ` [PATCH pve-manager v3 2/3] api: provide GUI versions via index and /cluster/resources Dominik Csapak
2026-11-19 17:09 ` [PATCH pve-manager v3 3/3] ui: workspace: prompt user for reload when UI packages were updated Dominik Csapak
2026-11-19 22:21 ` [PATCH pve-manager v3 0/3] ui: prompt users for reload when web ui version changes Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119171151.475428-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal