From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage v3 2/2] file_size_info: cast 'size' and 'used' to integer
Date: Mon, 21 Feb 2022 16:08:54 +0100 [thread overview]
Message-ID: <6d33d649-3368-9727-f788-f17934e31911@proxmox.com> (raw)
In-Reply-To: <20220218085827.52533-2-m.limbeck@proxmox.com>
On 18.02.22 09:58, Mira Limbeck wrote:
> `qemu-img info --output=json` returns the size and used values as integers in
> the JSON format, but the regex match converts them to strings.
> As we know they only contain digits, we can simply cast them back to integers
> after the regex.
>
> The API requires them to be integers.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> v3:
> - changed comment to a short one
> - added R-b tag
> v2:
> - reworded commit subject and message
>
> PVE/Storage/Plugin.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>
applied, thanks!
next prev parent reply other threads:[~2022-02-21 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 8:58 [pve-devel] [PATCH v3 storage 1/2] fix #3894: " Mira Limbeck
2022-02-18 8:58 ` [pve-devel] [PATCH storage v3 2/2] file_size_info: " Mira Limbeck
2022-02-21 15:08 ` Thomas Lamprecht [this message]
2022-02-21 15:08 ` [pve-devel] applied: [PATCH v3 storage 1/2] fix #3894: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d33d649-3368-9727-f788-f17934e31911@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.