all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-acme 0/2] add missing _clearaccountconf_mutable and improve check-missing script
Date: Tue, 21 Feb 2023 17:29:13 +0100	[thread overview]
Message-ID: <6cd0508e-9a88-0e43-8003-8583685f9253@proxmox.com> (raw)
In-Reply-To: <20230221131318.4043599-1-s.ivanov@proxmox.com>

Am 21/02/2023 um 14:13 schrieb Stoiko Ivanov:
> I think I've seen similar reports a few times in our community-forum, but
> never followed through - or thought it was fixed by some other issue:
> https://forum.proxmox.com/threads/.122961/
> 
> While fixing the concrete issue for dns_cf.sh I tried to enhance our
> check-missing-function helper to catch such issues (now it caught the
> missing _clearaccountconf_mutable).
> 
> Patches are ordered inversely to their implementation, so that `make deb`
> does not fail on the first commit.
> 
> Stoiko Ivanov (2):
>   proxmox-acme: add empty _clearaccountconf_mutable helper
>   tests: add non-word boundary to present functions
> 
>  src/proxmox-acme                    | 4 ++++
>  src/test/check-missing-functions    | 4 ++--
>  src/test/missing-functions.expected | 1 +
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 


applied series, thanks!




      parent reply	other threads:[~2023-02-21 16:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 13:13 [pve-devel] " Stoiko Ivanov
2023-02-21 13:13 ` [pve-devel] [PATCH proxmox-acme 1/2] proxmox-acme: add empty _clearaccountconf_mutable helper Stoiko Ivanov
2023-02-21 13:13 ` [pve-devel] [PATCH proxmox-acme 2/2] tests: add non-word boundary to present functions Stoiko Ivanov
2023-02-21 16:29 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cd0508e-9a88-0e43-8003-8583685f9253@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal