[pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 26/03/2024 um 10:16 schrieb Christian Ebner:
> For certain network setups the default values currently used to send
> a wake on lan magic packet are not correct, e.g. it will get send via
> the interface for which the default gateway is configured.
> 
> This patches add optional configuration options to set a bind
> interface, over which to send the WoL packet and/or set a broadcast
> address to use.
> 
> The functionality was tested by listening on all interfaces of the
> sending host via `tcpdump -i any udp port 9`, and testing the
> combinations of
> 
> `pvenode config set -wakeonlan XX:XX:XX:XX:XX:XX,bind-interface=<iface-name>`
> 
> and
> 
> `pvenode config set -wakeonlan XX:XX:XX:XX:XX:XX,broadcast-address=<broadcast-address>`.
> 
> See also the thread in the community forum
> https://forum.proxmox.com/threads/123459/
> 
> pve-manager:
> 
> Christian Ebner (3):
>   node: config: make wakeonlan a property string
>   fix #5255: node: wol: add optional bind interface
>   fix #5255: node: wol: configurable broadcast address
> 
>  PVE/API2/Nodes.pm | 23 ++++++++++++++++----
>  PVE/NodeConfig.pm | 53 +++++++++++++++++++++++++++++++++++++++++------
>  2 files changed, 66 insertions(+), 10 deletions(-)
> 
> pve-docs:
> 
> Christian Ebner (1):
>   pvenode/wake-on-lan: mention optional config options
> 
>  pvenode.adoc | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 


applied, thanks!

I did some very minor follow-ups mostly to document the current default in
the schema and docs and a small style fix (well not even really style wise,
but rather making the part with assigning and checking the $bind_interface
variable slightly shorter).

While this is slightly niche it might still make sense to add this to the
web UI too (WoL is exposed via Node -> Options) for completeness sake.