Re: [pbs-devel] [PATCH proxmox-backup 4/4] ui: verify: add option to set number of threads for job

[Christian Ebner <c.ebner@proxmox.com>]

Same comment with respect to commit title as for some of the other 
patches, a short description on why this is done would be nice. E.g.

Exposes the worker-threads property in the verification job config 
window and verify all window so the user can update the values accordingly.

one comment below

On 11/5/25 4:51 PM, Nicolas Frey wrote:
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>   www/window/VerifyAll.js     | 12 ++++++++++++
>   www/window/VerifyJobEdit.js | 13 +++++++++++++
>   2 files changed, 25 insertions(+)
> 
> diff --git a/www/window/VerifyAll.js b/www/window/VerifyAll.js
> index 01bcd63d..82f62aae 100644
> --- a/www/window/VerifyAll.js
> +++ b/www/window/VerifyAll.js
> @@ -80,6 +80,18 @@ Ext.define('PBS.window.VerifyAll', {
>                           },
>                       ],
>                   },
> +
> +                {
> +                    xtype: 'proxmoxintegerfield',
> +                    name: 'worker-threads',
> +                    fieldLabel: gettext('# of Worker Threads'),
> +                    emptyText: '1',
> +                    minValue: 1,
> +                    maxValue: 32,
> +                    cbind: {
> +                        deleteEmpty: '{!isCreate}',
> +                    },
> +                },
>               ],
>           },
>       ],
> diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js
> index e87ca069..7b7a96c4 100644
> --- a/www/window/VerifyJobEdit.js
> +++ b/www/window/VerifyJobEdit.js
> @@ -166,5 +166,18 @@ Ext.define('PBS.window.VerifyJobEdit', {
>                   },
>               },
>           ],
> +        advancedColumn2: [
> +            {
> +                xtype: 'proxmoxintegerfield',
> +                name: 'worker-threads',
> +                fieldLabel: gettext('# of Worker Threads'),
> +                emptyText: '1',
> +                minValue: 1,
> +                maxValue: 32,
> +                cbind: {
> +                    deleteEmpty: '{!isCreate}',
> +                },
> +            },
> +        ]

it would be nice to also delete the value again if set to the default.

Further, just noticed: this now seemingly defaults to 1, which is also 
the default for the API schema, but the parallel task instantiation gets 
a default of 4 if the value is not set and therefore unwrapped? That 
should be made consistent.

>       },
>   });



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel