From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH common/qemu-server v5] improve sysfs write behaviour
Date: Mon, 11 Nov 2024 20:34:50 +0100 [thread overview]
Message-ID: <6a670f5b-37af-4eca-8434-3bdee5e31f69@proxmox.com> (raw)
In-Reply-To: <20241111110520.1803627-1-d.csapak@proxmox.com>
Am 11.11.24 um 12:05 schrieb Dominik Csapak:
> and fix passthrough regressions
>
> As i feared previously in [0], making it a hard error when encountering
> errors during sysfs writes uncovered some situations where our code was
> too strict to keep some setups working.
>
> One such case is resetting devices, which is seemingly not necessary
> at all times, so this series
>
> * donwgrades that error to warning
> * adds some more logging to `file_write` to be able to better debug
>
> Another case that broke was passing through similar devices with the
> same vendor/modelid since the write to vfio-pci's 'new_id' works only
> once for the same vendor/modelid.
>
> To fix that make EEXIST errors ignorable for file_write
>
> changes from v4:
> * extract $! into variable before close
>
> changes from v3:
> * common patch 1/2 is now only adding the logging again
> * add a single option for ignoring EEXIST, if we need more in the future
>
> changes from v2:
> * improve comment on file_write
> * shorten code with suggestions from stoiko
> * fix commit message
>
> changes from v1:
> * also include error ignore list
> * ignore EEXIST for writing to new_id
>
> 0: https://lore.proxmox.com/pve-devel/20240723082925.934603-1-d.csapak@proxmox.com/
>
> pve-common:
>
> Dominik Csapak (2):
> sysfstools: file_write: extend with logging
> sysfstools: fix regression on binding to vfio-pci
>
> src/PVE/SysFSTools.pm | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> qemu-server:
>
> Dominik Csapak (1):
> pci: don't hard require resetting devices for passthrough
>
> PVE/QemuServer/PCI.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
applied all three patches with some minor opinionated clean-ups, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-11 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 11:05 [pve-devel] " Dominik Csapak
2024-11-11 11:05 ` [pve-devel] [PATCH common v5 1/2] sysfstools: file_write: extend with logging Dominik Csapak
2024-11-11 11:05 ` [pve-devel] [PATCH common v5 2/2] sysfstools: fix regression on binding to vfio-pci Dominik Csapak
2024-11-11 11:05 ` [pve-devel] [PATCH qemu-server v5 1/1] pci: don't hard require resetting devices for passthrough Dominik Csapak
2024-11-11 19:34 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a670f5b-37af-4eca-8434-3bdee5e31f69@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.