From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH pve-installer 6/6] closes #5757: common: add checks for valid IPv4 address within subnet
Date: Mon, 28 Apr 2025 16:20:53 +0200 [thread overview]
Message-ID: <6a413f16-71b7-4582-88c4-3ace1f347a26@proxmox.com> (raw)
In-Reply-To: <D9I74CTEHVFV.POZJ09D616IN@proxmox.com>
On 4/28/25 12:22, Christoph Heiss wrote:
> At least for IPv4 /31 prefixes, this check (including the network
> address part) is wrong. RFC 3021 [0] explicitly allows such subnets for
> point-to-point links.
>
> E.g. 192.168.0.0/31 is a valid subnet with 2 hosts, 192.168.0.0/31 and
> 192.168.0.1/31.
>
> [0] https://www.rfc-editor.org/rfc/rfc3021
You're right, I missed that. Thanks! I think for /32 and /31 it makes
sense to explicitly allow them, avoiding the calculations done for any
other valid subnet mask. I'll adapt the implementation accordingly in a v2.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-28 14:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 16:27 [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 1/6] auto: add early answer file sanity check for RAID configurations Michael Köppl
2025-04-28 11:25 ` Christoph Heiss
2025-04-28 14:31 ` Michael Köppl
2025-04-29 8:26 ` Christoph Heiss
2025-04-29 9:32 ` Michael Köppl
2025-04-29 9:40 ` Christoph Heiss
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 2/6] common: use get_min_disks as single source of truth for RAID config checks Michael Köppl
2025-04-28 11:48 ` Christoph Heiss
2025-04-28 15:36 ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [RFC PATCH pve-installer 3/6] close #5887: add sanity check for LVM swapsize and maxroot Michael Köppl
2025-04-28 12:00 ` Christoph Heiss
2025-04-29 11:30 ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 4/6] run rustfmt Michael Köppl
2025-04-23 11:56 ` Christoph Heiss
2025-04-25 12:22 ` Michael Köppl
2025-04-22 16:27 ` [pve-devel] [PATCH pve-installer 5/6] common: add more descriptive errors for invalid network configs Michael Köppl
2025-04-28 12:20 ` Christoph Heiss
2025-04-22 16:27 ` [pve-devel] [RFC PATCH pve-installer 6/6] closes #5757: common: add checks for valid IPv4 address within subnet Michael Köppl
2025-04-28 10:22 ` Christoph Heiss
2025-04-28 14:20 ` Michael Köppl [this message]
2025-04-28 12:25 ` [pve-devel] [PATCH installer 0/6] add early disk and network sanity checks Christoph Heiss
2025-04-29 14:14 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a413f16-71b7-4582-88c4-3ace1f347a26@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal