all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES] remove replicated volumes on guest purge
Date: Thu, 28 Jan 2021 17:20:47 +0100	[thread overview]
Message-ID: <6a3087eb-4fe3-c282-99a5-c2b697fdb72b@proxmox.com> (raw)
In-Reply-To: <20201014113628.14286-1-f.ebner@proxmox.com>

On 14.10.20 13:36, Fabian Ebner wrote:
> Introduces two helper functions in Replication.pm and ReplicationConfig.pm
> so that the guests can do the removal easily.
> 
> destroy_vm contains a check whether the guest is still in use by a
> linked clone (in the LXC case triggered by the storage backend at vdisk_free),
> so that needs to happen first.
> That check could be factored out and removing replicated volumes moved
> to before destroy_vm, but I feel like it's cleaner to first destroy the
> VM and do all related cleanups later (as it is now).
> 
> The problem is that the guest config does not contain any volumes
> after destroy_vm, and run_full_removal would do nothing, because
> on removal, run_replication currently only considers storages that
> show up in the config and not those from the replication job state.
> 
> Therefore, this depends on the following patch to be applied first:
> https://lists.proxmox.com/pipermail/pve-devel/2020-October/045386.html
> 
> Dependency bumps: qemu-server,pve-container -> pve-guest-common
> are needed for patches #2 and #3
> and I think the reverse bumps are needed for patch #4
> 

Besides that, is this still relevant? If so, it may need some rebasing,
at least guest-common does.




  parent reply	other threads:[~2021-01-28 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 11:36 Fabian Ebner
2020-10-14 11:36 ` [pve-devel] [PATCH guest-common 1/5] add list_local_jobs and run_full_removal functions Fabian Ebner
2020-10-14 11:36 ` [pve-devel] [PATCH qemu-server 2/5] remove replicated volumes on purge Fabian Ebner
2020-10-14 11:36 ` [pve-devel] [PATCH container 3/5] " Fabian Ebner
2020-10-14 11:36 ` [pve-devel] [PATCH guest-common 4/5] remove the now unused remove_vmid_jobs Fabian Ebner
2020-10-14 11:36 ` [pve-devel] [PATCH guest-common 5/5] cleanup: iterate over values in find_local_replication_job Fabian Ebner
2021-01-28 16:20 ` Thomas Lamprecht [this message]
2021-01-29 10:12   ` [pve-devel] [PATCH-SERIES] remove replicated volumes on guest purge Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3087eb-4fe3-c282-99a5-c2b697fdb72b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal