Re: [pbs-devel] [PATCH proxmox-offline-mirror] mirror: add support for trixie repositories

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 27/08/2025 16:25, Shannon Sterz wrote:
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  src/bin/proxmox-offline-mirror.rs | 99 +++++++++++++++++++++----------
>  1 file changed, 69 insertions(+), 30 deletions(-)
> 

> @@ -353,6 +382,15 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
>  
>                  // TODO enterprise query for key!
>                  let url = match (release, variant) {
> +                    (Release::Trixie, ProxmoxVariant::Enterprise) => format!(
> +                        "https://enterprise.proxmox.com/debian/{product} trixie {product}-enterprise"
> +                    ),
> +                    (Release::Trixie, ProxmoxVariant::NoSubscription) => format!(
> +                        "http://download.proxmox.com/debian/{product} trixie {product}-no-subscription"
> +                    ),
> +                    (Release::Trixie, ProxmoxVariant::Test) => {
> +                        format!("http://download.proxmox.com/debian/{product} trixie {product}test")

Since trixie the test repo is also finally kebab-case, i.e. above needs to
use "... trixie {product}-test"

> +                    }
>                      (Release::Bookworm, ProxmoxVariant::Enterprise) => format!(
>                          "https://enterprise.proxmox.com/debian/{product} bookworm {product}-enterprise"
>                      ),
> @@ -390,6 +428,7 @@ fn action_add_mirror(config: &SectionConfigData) -> Result<Vec<MirrorConfig>, Er
>                  };
>  
>                  let key = match release {
> +                    Release::Trixie => "/etc/apt/trusted.gpg.d/proxmox-release-trixie.gpg",

Only checking the diff not the full context, but should we use the
relatively new common archive keyring in /usr here?

>                      Release::Bookworm => "/etc/apt/trusted.gpg.d/proxmox-release-bookworm.gpg",
>                      Release::Bullseye => "/etc/apt/trusted.gpg.d/proxmox-release-bullseye.gpg",
>                      Release::Buster => "/etc/apt/trusted.gpg.d/proxmox-release-buster.gpg",



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel