Re: [PATCH yew-widget-toolkit 2/2] widget: form: number: allow focusing the input on click

[Dominik Csapak <d.csapak@proxmox.com>]

@Dietmar

i applied this one since it fixed the focus issue for nubmer fields.
Looking at the code this slipped in with the changes to the managedfield
interface, but the commit message (and code) don't give a full 
explanation for this onmousedown handler.
(only 'prevent focus loss')

Can you remember in what situations we lost the focus or where there
were problems? Since i couldn't find any...

On 3/19/26 6:04 PM, Christoph Heiss wrote:
> The `.prevent_default()` on the input elements `onmousedown` handler is
> not needed and actually prevents the input from being focused by
> clicking, since the event will never reach it. Drop it.
> 
> The returned `SpinnerStop` value is just a dummy, so safe to remove the
> entire handler.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>   src/widget/form/number.rs | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/src/widget/form/number.rs b/src/widget/form/number.rs
> index 6db7063..82d66b4 100644
> --- a/src/widget/form/number.rs
> +++ b/src/widget/form/number.rs
> @@ -665,12 +665,6 @@ impl<T: NumberTypeInfo> ManagedField for NumberField<T> {
>               }
>           });
>   
> -        let on_mouse_down = ctx.link().callback(|event: MouseEvent| {
> -            // prevent focus loss
> -            event.prevent_default();
> -            Msg::SpinnerStop // dummy
> -        });
> -
>           let input_props = props.input_props.clone();
>   
>           let inputmode = if T::is_decimal() {
> @@ -702,7 +696,6 @@ impl<T: NumberTypeInfo> ManagedField for NumberField<T> {
>                       event.prevent_default();
>                   }
>               })
> -            .onmousedown(on_mouse_down)
>               .into_html_with_ref(self.input_ref.clone());
>   
>           let mut input_container = Tooltip::empty()