[pve-devel] [PATCH qemu-server] vzdump: assemble: improve error messages

[pve-devel] [PATCH qemu-server] vzdump: assemble: improve error messages

[Fiona Ebner]

by including the errno. Might make it clearer what the issue is in
cases like: https://forum.proxmox.com/threads/135261/

Also add the missing newlines, the missing "to" in the second message,
switch to the more common "or die" and avoid line bloat while at it.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/VZDump/QemuServer.pm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index f811cbf2..be7d8e1e 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -222,10 +222,8 @@ sub assemble {
     my $firewall_src = "/etc/pve/firewall/$vmid.fw";
     my $firewall_dest = "$task->{tmpdir}/qemu-server.fw";
 
-    my $outfd = IO::File->new (">$outfile") ||
-	die "unable to open '$outfile'";
-    my $conffd = IO::File->new ($conffile, 'r') ||
-	die "unable open '$conffile'";
+    my $outfd = IO::File->new(">$outfile") or die "unable to open '$outfile' - $!\n";
+    my $conffd = IO::File->new($conffile, 'r') or die "unable to open '$conffile' - $!\n";
 
     my $found_snapshot;
     my $found_pending;
-- 
2.39.2

[pve-devel] applied: [PATCH qemu-server] vzdump: assemble: improve error messages

[Thomas Lamprecht]

Am 23/10/2023 um 10:59 schrieb Fiona Ebner:
> by including the errno. Might make it clearer what the issue is in
> cases like: https://forum.proxmox.com/threads/135261/
> 
> Also add the missing newlines, the missing "to" in the second message,
> switch to the more common "or die" and avoid line bloat while at it.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/VZDump/QemuServer.pm | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
>

applied, thanks!