From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-manager v5 2/2] guest: refactor and reuse AgentIPView for containers
Date: Sat, 15 Nov 2025 18:16:27 +0100 [thread overview]
Message-ID: <690d6786-f70a-41e7-b231-d064c2d6f6dd@proxmox.com> (raw)
In-Reply-To: <20250527140446.365983-3-g.goller@proxmox.com>
Am 27.05.25 um 16:04 schrieb Gabriel Goller:
> Refactor AgentIPView to be generic over container and vms. Reuse it in
> the Container Summary to show the ip addresses of the container. Also
> make the GuestSummary scrollable, as it can potentially be bigger
> (because of the ip-addresses that can be shown) than 300 (which is the
> size of the RRD graphs).
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> www/manager6/Makefile | 2 +-
> www/manager6/panel/GuestStatusView.js | 140 +++++++++++++++++-
> www/manager6/panel/GuestSummary.js | 1 +
> .../{qemu/AgentIPView.js => panel/IPView.js} | 79 ++--------
> 4 files changed, 151 insertions(+), 71 deletions(-)
> rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (58%)
>
>
I rechecked the changes and I disliked the callback approach, so I reworked
this to rather using a base class and two specialized sub-classes, one for
VMs and one for CTs. This encapsulates underlying details better, one that
instantiates these widgets somewhere should not have to care about (plus
doing so crowds the use-sites code).
That said, your changes itself where quite well structured, so adapting it
wasn't much of a hassle, besides one ExtJS bug (IMO) getting in my way
quite a bit, see another follow-up for some more info on that though.
.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-15 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 14:04 [pve-devel] [PATCH manager v5 0/2] Show container ip in summary and network tab Gabriel Goller
2025-05-27 14:04 ` [pve-devel] [PATCH pve-manager v5 1/2] lxc: show dynamically assigned IPs in " Gabriel Goller
2025-11-15 17:12 ` [pve-devel] applied: " Thomas Lamprecht
2025-05-27 14:04 ` [pve-devel] [PATCH pve-manager v5 2/2] guest: refactor and reuse AgentIPView for containers Gabriel Goller
2025-11-15 17:16 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=690d6786-f70a-41e7-b231-d064c2d6f6dd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.