From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] applied: [PATCH cluster v2 2/3] RRD: fetch data from old rrd file if present and needed
Date: Tue, 11 Nov 2025 12:14:13 +0100 [thread overview]
Message-ID: <68a53042-4b5c-4540-82c9-56f11bd92e30@proxmox.com> (raw)
In-Reply-To: <176280281155.3000805.13988201036395926641.b4-ty@proxmox.com>
the follow up changes in 2316ac8bcd19142f8253e13a2a5c427dc6cfac67 look good.
I built pve-cluster with the latest master and tested it with the not
yet applied patches for the other involved repos in this series on my
personal production machine.
Going through the summary pages of different resources still worked as
in my earlier test.
On 2025-11-10 20:28, Thomas Lamprecht wrote:
> On Mon, 03 Nov 2025 23:00:17 +0100, Aaron Lauterer wrote:
>> One side effect of the RRD migration is that MAX spikes are flattened
>> due to the new more fine grained resolution.
>>
>> If we request RRD data that was still covered in the old rrd file, we
>> can fetch those data from there and then append newer data from the new
>> RRD files. This way, we still have the older more coarse resolution for
>> the old data and keep spikes present.
>>
>> [...]
>
> Applied, with some clean-ups/refcatoring in two follow-ups (maybe you can take
> another look on them to ensure I didn't miss something) thanks!
>
> [2/3] RRD: fetch data from old rrd file if present and needed
> commit: e43b29e90e5ac73e81292a8c32f8b6230b65b2a4
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-11 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 22:00 [pve-devel] [PATCH cluster/container/manager/qemu-server/storage v2 0/7] combine and simplify RRD handling Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 1/3] rrd: fix rrd time frames Aaron Lauterer
2025-11-10 19:26 ` [pve-devel] applied: " Thomas Lamprecht
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 2/3] RRD: fetch data from old rrd file if present and needed Aaron Lauterer
2025-11-10 19:26 ` [pve-devel] applied: " Thomas Lamprecht
2025-11-11 11:14 ` Aaron Lauterer [this message]
2025-11-03 22:00 ` [pve-devel] [PATCH cluster v2 3/3] pmxcfs: status.c: always use 9.0 rrd files Aaron Lauterer
2025-11-10 19:26 ` [pve-devel] applied: " Thomas Lamprecht
2025-11-03 22:00 ` [pve-devel] [PATCH manager v2 1/1] status: rrddata: use fixed pve-node-9.0 path Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH qemu-server v2 1/1] status: rrddata: use fixed pve-vm-9.0 path Aaron Lauterer
2025-11-12 14:23 ` [pve-devel] applied: " Thomas Lamprecht
2025-11-03 22:00 ` [pve-devel] [PATCH container " Aaron Lauterer
2025-11-03 22:00 ` [pve-devel] [PATCH storage v2 1/1] status: rrddata: use fixed pve-storage-9.0 path Aaron Lauterer
2025-11-13 6:48 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a53042-4b5c-4540-82c9-56f11bd92e30@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.