Re: [pve-devel] [PATCH widget-toolkit/manager v2 0/4] Ceph OSD: add detail infos

[Dominik Csapak <d.csapak@proxmox.com>]

On 10/18/22 11:14, Aaron Lauterer wrote:
> 
> 
> On 10/17/22 16:29, Dominik Csapak wrote:
>> high level looks mostly good, a small question:
>>
>> is there a special reason why we ignore pre-lvm osds here?
>> AFAICS, we simply error out for osds that don't live on lvm
>> (though we can add additional types later i guess)
> 
> Mainly because with a recent Ceph version, you shouldn't have any pre Bluestore OSDs anymore. With 
> Quincy, they have officially been deprecated. And even before, for quite a few versions, every new 
> OSD would be a bluestore one.
> 
> So I did not want to do the work for the old filestore OSDs. Once a new generation of OSDs becomes 
> available, we will need to handle them as well though.
> 

just to have record about what we talked off-list yesterday:

i didn't mean 'pre-bluestore' osds, but bluestore osds that don't use lvm
iow. created with ceph-disk instead of ceph-volume (from luminous/pve5)

also imho we don't have to show any useful infos there (if we even had some)
but maybe show a little less 'scary' warning like
'cannot show lvm info for osd's created before pve 6/ceph nautilus' or similar