From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH common 1/1] CalendarEvent: use rust implementation
Date: Thu, 13 Jan 2022 17:20:56 +0100 [thread overview]
Message-ID: <688038e8-1cb6-4cf6-2058-ee793b67bda0@proxmox.com> (raw)
In-Reply-To: <20211201085514.1648428-3-d.csapak@proxmox.com>
On 01.12.21 09:55, Dominik Csapak wrote:
> by replacing the parsing code and 'compute_next_event' by their
> PVE::RS::CalendarEvent equivalent
>
> adapt the tests, since we do not have access to the internal structure
> (and even if we had, it would be different) and the error messages
> are different
>
> the 'compute_next_event' and parsing tests still pass though
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/CalendarEvent.pm | 251 +-----------------------------------
> test/calendar_event_test.pl | 42 +++---
> 2 files changed, 23 insertions(+), 270 deletions(-)
>
> diff --git a/src/PVE/CalendarEvent.pm b/src/PVE/CalendarEvent.pm
> index 56e9923..e2bf53a 100644
> --- a/src/PVE/CalendarEvent.pm
> +++ b/src/PVE/CalendarEvent.pm
> @@ -6,6 +6,7 @@ use Data::Dumper;
> use Time::Local;
> use PVE::JSONSchema;
> use PVE::Tools qw(trim);
> +use PVE::RS::CalendarEvent;
this is actually not ideal as pve-common is also used in PMG and for some infra stuff, so
pve-rs isn't available there everywhere...
hacked around that for now by just dropping the d/control dependency for now, as I depend
on the correct pve-rs version in pve-manager directly anyway...
next prev parent reply other threads:[~2022-01-13 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 8:55 [pve-devel] [PATCH proxmox-perl-rs/common] use calendar-events from rust Dominik Csapak
2021-12-01 8:55 ` [pve-devel] [PATCH 1/1] pve-rs: add PVE::RS::CalendarEvent Dominik Csapak
2021-12-01 8:55 ` [pve-devel] [PATCH common 1/1] CalendarEvent: use rust implementation Dominik Csapak
2022-01-13 16:20 ` Thomas Lamprecht [this message]
2022-01-13 14:45 ` [pve-devel] applied-series: [PATCH proxmox-perl-rs/common] use calendar-events from rust Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=688038e8-1cb6-4cf6-2058-ee793b67bda0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal