From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
"nansen.su" <nansen.su@sianit.com>
Subject: Re: [pve-devel] [PATCH pve-manager] metrics add OpenTelemetry support
Date: Tue, 15 Jul 2025 09:26:16 +0200 [thread overview]
Message-ID: <683e17d4-85e5-489e-b735-75810709bef6@proxmox.com> (raw)
In-Reply-To: <ab3228ec-07e8-4b96-9efe-833065af2b91@proxmox.com>
On 7/15/25 08:52, Thomas Lamprecht wrote:
> Am 15.07.25 um 05:55 schrieb nansen.su:
[snip]>> +
>> +sub type {
>> + return 'opentelemetry';
>> +}
>> +
>> +sub properties {
>> + return {
>> + 'otel-protocol' => {
>
> I'm fine with the plugin specific otel prefix, but @Dominik: these here might be
> a good fit for the property separation? It's not many plugins and each of them has
> not that many properties. Or do you know anything that would speak against this?
>
> Anyhow, nothing that needs to block this for real and nothing you @Nansen Su need
> to worry about.
>
Yes, the property isolation should be working fine here, at least no blocker
comes to mind. If we do that afterwards though, the property-names are still
prefixed, so we'd have to reintroduce them without prefix + deprecate, etc.
(or we just leave them prefixed)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-15 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 3:55 nansen.su
2025-07-15 6:52 ` Thomas Lamprecht
2025-07-15 7:26 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=683e17d4-85e5-489e-b735-75810709bef6@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=nansen.su@sianit.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.